Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#319 adding 3 columns to matchmaker_queue_map_pool table #320

Merged
merged 2 commits into from
Nov 24, 2024
Merged

#319 adding 3 columns to matchmaker_queue_map_pool table #320

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a39c0
#319 adding 3 columns to matchmaker_queue_map_pool table
K-ETFreeman Oct 12, 2024
920498f
column rename + file ext fix
K-ETFreeman Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions migrations/V135__add_veto_fields_to_matchmaker_queue_map_pool
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
ALTER TABLE matchmaker_queue_map_pool
ADD COLUMN veto_tokens_per_player TINYINT UNSIGNED DEFAULT 0 NOT NULL,
ADD COLUMN max_tokens_per_map TINYINT UNSIGNED DEFAULT 0 NOT NULL,
ADD COLUMN minimal_maps_allowed FLOAT DEFAULT 1 NOT NULL CHECK (minimal_maps_allowed >= 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name minimal_maps_allowed differently. It is a restriction, not an allowance. I get what it is supposed to mean, but it is a bit confusing. Maybe minimal_maps_left?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand either of the names. What is the effect of this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand either of the names. What is the effect of this value?

its the minimal maps count which should left after all vetoes applied

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

system will nerf veto tokens if necessary until this is true

Copy link
Contributor Author

@K-ETFreeman K-ETFreeman Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about the name i dont really care, but PRs to the api and mod client should also be changed accordingly, if you change it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like minimum_maps_after_veto. It's a descriptive name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i will set "minimum_maps_after_veto" and will update other repos / PRs accordingly

Copy link
Contributor Author

@K-ETFreeman K-ETFreeman Nov 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to set it like CHECK (minimum_maps_after_veto > 0)
but this can lead to questions like "what is 0.5 maps after veto means"
should i rename it to "minimal_sum_of_map_weights_after_veto" instead?

Copy link
Contributor Author

@K-ETFreeman K-ETFreeman Nov 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be more accurate description of the variable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlackYps @Brutus5000

Loading