Fix strain to stress conversion in TensorMap class, better TensorMap documentation #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwright
reviewed
Oct 29, 2024
ImageD11/sinograms/tensor_map.py
Outdated
| # rotate the strain tensor from ImageD11 coordinate system to IEEE 1976 coordinate system | ||
| # determine rotation matrix E | ||
| C_c = np.linalg.inv(B0).T | ||
| E = np.column_stack((C_c[:, 0], np.cross(C_c[:, 2], C_c[:, 0]), C_c[:, 2])) |
There was a problem hiding this comment.
Looks extremely dodgy. Not a rotation.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The IEEE <-> ImageD11 rotation has now been removed from |
|
Sure - go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now compute the Biot stress tensor in the crystal reference frame (ImageD11 convention), given a Biot strain tensor in the crystal reference frame (ImageD11 convention, the default obtained when calling
ImageD11.grain.eps_crystal_matrix(dzero_cell)) and a 6x6 stiffness tensor (Voigt-compatible, IEEE 1976 lattice convention, what materialsproject.org gives you).Thanks to @AxelHenningsson and @jonwright for discussions on this.
Partially fixes #194 - the dream is to move the
Numbakernels fromtensor_map.pyintostress.pyeventually