Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #902 fixed #909

Merged
merged 1 commit into from
Dec 21, 2023
Merged

issue #902 fixed #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bigip/resource_bigip_ltm_profile_ssl_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,10 @@
},

"cipher_group": {
Type: schema.TypeString,

Check failure on line 268 in bigip/resource_bigip_ltm_profile_ssl_client.go

View workflow job for this annotation

GitHub Actions / golint 

File is not `gofmt`-ed with `-s` (gofmt)
Optional: true,
Default: "none",
Computed: true,
// Default: "none",
Description: "Cipher group for the ssl client profile",
ConflictsWith: []string{"ciphers"},
},
Expand Down
13 changes: 11 additions & 2 deletions bigip/resource_bigip_ltm_profile_ssl_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@

import (
"fmt"
"testing"

Check failure on line 10 in bigip/resource_bigip_ltm_profile_ssl_client_test.go

View workflow job for this annotation

GitHub Actions / golint 

File is not `gofmt`-ed with `-s` (gofmt)

bigip "github.com/f5devcentral/go-bigip"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
Expand Down Expand Up @@ -413,7 +412,17 @@
resource.TestCheckResourceAttr(resFullName, "name", instFullName),
resource.TestCheckResourceAttr(resFullName, "partition", "Common"),
resource.TestCheckResourceAttr(resFullName, "defaults_from", "/Common/clientssl"),
resource.TestCheckResourceAttr(resFullName, "cipher_group", "none"),
// resource.TestCheckResourceAttr(resFullName, "cipher_group", "none"),
),
},
{
Config: testaccbigipltmprofileclientsslUpdateparam(instName, "cipher_group"),
Check: resource.ComposeTestCheckFunc(
testCheckClientSslExists(instFullName),
resource.TestCheckResourceAttr(resFullName, "name", instFullName),
resource.TestCheckResourceAttr(resFullName, "partition", "Common"),
resource.TestCheckResourceAttr(resFullName, "defaults_from", "/Common/clientssl"),
resource.TestCheckResourceAttr(resFullName, "cipher_group", "/Common/f5-aes"),
),
},
{
Expand Down
Loading