Added transaction to resource_bigip_ssl_key_cert

bigip/resource_bigip_ssl_key_cert.go

@@ -97,6 +97,10 @@
 		Passphrase: passphrase,
 	}
 
+	t, err := client.StartTransaction()
+	if err != nil {
+		return diag.FromErr(fmt.Errorf("error while starting transaction: %v", err))
+	}
 	err = client.AddKey(&keyCfg)
 	if err != nil {
 		return diag.FromErr(fmt.Errorf("error while adding the ssl key: %v", err))
@@ -105,6 +109,10 @@
 	if err != nil {
 		return diag.FromErr(fmt.Errorf("error while uploading the ssl cert: %v", err))
 	}
+	err = client.CommitTransaction(t.TransID)
+	if err != nil {
+		return diag.FromErr(fmt.Errorf("error while ending transaction: %d", err))
+	}
 
 	id := keyName + "_" + certName
 	d.SetId(id)
@@ -166,6 +174,11 @@
 	}
 
 	keyFullPath := fmt.Sprintf("/%s/%s", partition, keyName)
+
+	t, err := client.StartTransaction()
+	if err != nil {
+		return diag.FromErr(fmt.Errorf("error while trying to start transaction: %s", err))
+	}
 	err = client.ModifyKey(keyFullPath, &keyCfg)
 	if err != nil {
 		return diag.FromErr(fmt.Errorf("error while trying to modify the ssl key (%s): %s", keyFullPath, err))
@@ -175,6 +188,10 @@
 	if err != nil {
 		return diag.FromErr(fmt.Errorf("error while updating the ssl certificate (%s): %s", certName, err))
 	}
+	err = client.CommitTransaction(t.TransID)
+	if err != nil {
+		return diag.FromErr(fmt.Errorf("error while trying to end transaction: %s", err))
+	}
 
 	return resourceBigipSSLKeyCertRead(ctx, d, meta)
 }
@@ -191,7 +208,12 @@
 	keyFullPath := "/" + partition + "/" + keyName
 	certFullPath := "/" + partition + "/" + certName
 
-	err := client.DeleteKey(keyFullPath)
+	t, err := client.StartTransaction()
+	if err != nil {
+		return diag.FromErr(fmt.Errorf("error while starting transaction: %v", err))
+	}
+
+	err = client.DeleteKey(keyFullPath)
 	if err != nil {
 		log.Printf("[ERROR] unable to delete the ssl key (%s) (%v) ", keyFullPath, err)
 	}
@@ -201,6 +223,11 @@
 		log.Printf("[ERROR] unable to delete the ssl certificate (%s) (%v) ", certFullPath, err)
 	}
 
+	err = client.CommitTransaction(t.TransID)
+	if err != nil {
+		return diag.FromErr(fmt.Errorf("error while ending transaction: %v", err))
+	}
+
 	d.SetId("")
 	return nil
 }

bigip/resource_bigip_ssl_key_cert_test.go

@@ -1,6 +1,9 @@
 package bigip
 
 import (
+	"fmt"
+	"log"
+	"os"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
@@ -16,6 +19,29 @@ resource "bigip_ssl_key_cert" "testkeycert" {
 }
 `
 
+var sslProfileCertKey = `
+resource "bigip_ssl_key_cert" "testkeycert" {
+  partition   = "Common"
+  key_name    = "ssl-test-key"
+  key_content = "${file("` + folder + `/../examples/%s")}"
+  cert_name    = "ssl-test-cert"
+  cert_content = "${file("` + folder + `/../examples/%s")}"
+}
+
+resource "bigip_ltm_profile_server_ssl" "test-ServerSsl" {
+  name          = "/Common/test-ServerSsl"
+  defaults_from = "/Common/serverssl"
+  authenticate  = "always"
+  ciphers       = "DEFAULT"
+  cert          = "/Common/ssl-test-cert"
+  key           = "/Common/ssl-test-key"
+
+  depends_on = [
+	bigip_ssl_key_cert.testkeycert
+  ]
+}
+`
+
 func TestAccBigipSSLCertKeyCreate(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck: func() {
@@ -45,3 +71,44 @@ func TestAccBigipSSLCertKeyCreate(t *testing.T) {
 		},
 	})
 }
+
+func TestAccBigipSSLCertKeyCreateCertKeyProfile(t *testing.T) {
+	create := fmt.Sprintf(sslProfileCertKey, "serverkey.key", "servercert.crt")
+	modify := fmt.Sprintf(sslProfileCertKey, "serverkey2.key", "servercert2.crt")
+	crt1Content, _ := os.ReadFile(folder + `/../examples/` + "servercert.crt")
+	key1Content, _ := os.ReadFile(folder + `/../examples/` + "serverkey.key")
+	crt2Content, _ := os.ReadFile(folder + `/../examples/` + "servercert2.crt")
+	key2Content, _ := os.ReadFile(folder + `/../examples/` + "serverkey2.key")
+
+	log.Println(create)
+	log.Println(modify)
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			testAcctPreCheck(t)
+		},
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: create,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "key_name", "ssl-test-key"),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "cert_name", "ssl-test-cert"),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "partition", "Common"),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "key_content", string(key1Content)),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "cert_content", string(crt1Content)),
+				),
+				Destroy: false,
+			},
+			{
+				Config: modify,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "key_name", "ssl-test-key"),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "cert_name", "ssl-test-cert"),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "partition", "Common"),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "key_content", string(key2Content)),
+					resource.TestCheckResourceAttr("bigip_ssl_key_cert.testkeycert", "cert_content", string(crt2Content)),
+				),
+			},
+		},
+	})
+}