fix: consider ruleWidth when zoom to fit #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可以解释一下代码的原理吗？ |
|
通过从视口尺寸中减去标尺宽度，calculateDimension函数可以准确确定可用于缩放和定位内容的实际空间，此调整可确保缩放的内容正确适合画布的可见区域。 在计算新视口位置时，将rulerWidth添加回来并除以newzoom，来补回之前由于计算实际空间减去的标尺宽度，而产生的向下和向又的偏移量，确保内容相对于整个视口（包括标尺区域）正确居中。 我已经测试了不同rulerWidth和屏幕宽度的计算情况，测试了其可以正确布局。 |
其实也就是先计算了把rulerWidth减去时候的视口空间时的布局， 然后根据rulerWidth/newZoom把这些损失的偏移又补回来 |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finish TODO: consider padding from ruler