Refactor and fix EXT-X-DEFINE and EXT-X-START #31
Conversation
tobbee
commented
Jan 19, 2025
tobbee
commented
- Refactored EXT-X-DEFINE
- Fixed EXT-X-START write for negative values
- Added EXT-X-START to media playlist
Both positive and negative offsets are allowed. The tag can appear in both master and media playlist
tobbee
force-pushed
the
refactor-and-fix
branch
from
46b15e8 to
b008de3
Compare
tobbee
force-pushed
the
refactor-and-fix
branch
from
b008de3 to
710fbdc
Compare
|
|
||
| for _, attr := range decodeAttributes(parameters) { | ||
| switch attr.Key { | ||
| case "TIME-OFFSET": |
There was a problem hiding this comment.
When parsing the time offset, should we return an error if the offset value does not conform to the spec?
from the RFC:
The absolute value of TIME-OFFSET SHOULD NOT be larger than the
Playlist duration. If the absolute value of TIME-OFFSET exceeds
the duration of the Playlist, it indicates either the end of the
Playlist (if positive) or the beginning of the Playlist (if
negative).
If the Playlist does not contain the EXT-X-ENDLIST tag, the TIME-
OFFSET SHOULD NOT be within three Target Durations of the end of
the Playlist file.
This might be overkill and hard to do with the structure of the packager, but could also be a nice to have feature.
There was a problem hiding this comment.
I think it would be useful, but, in my view, we should parse everything that is syntactically valid including if the version is wrong or some values too big or small, and then let the application, or a special validation phase handle such things.
Let's ponder it for later.
There was a problem hiding this comment.
That's a valid decision to make. In that case, feel free to merge whenever :)
