Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing scheduler build #970

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: fixing scheduler build #970

merged 1 commit into from
Sep 9, 2024

Conversation

9sneha-n
Copy link
Contributor

@9sneha-n 9sneha-n commented Sep 6, 2024

📌 References

📝 Implementation

Fix Scheduler build.

📹 Screenshots/Screen capture

🔥 Is there anything the reviewer should know to test it?

run yarn build-scheduler - a zip should be generated successfully.

📑 Others

  • Any change in the GUI library? If so, what branch/PR?

  • Any change in the D2 Api? If so, what branch/PR?

@ifoche
Copy link
Member

ifoche commented Sep 6, 2024

Copy link
Contributor

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, it's a not a critical component, it can be downgraded if that solves build problem. Eventually it should be updated, though.

@9sneha-n
Copy link
Contributor Author

9sneha-n commented Sep 9, 2024

@MiquelAdell Could you please merge this and create a release as we need to share the Scheduler zip with Zebra client.

Copy link
Member

@ifoche ifoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @9sneha-n

@ifoche ifoche merged commit 278ca2d into development Sep 9, 2024
1 check passed
@ifoche ifoche deleted the fix/scheduler-build-fix branch September 9, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants