exclude default categories from dataElements #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eperedo
force-pushed
the
fix/categories-default
branch
from
c0d94af to
4767357
Compare
MiquelAdell
approved these changes
Jun 10, 2024
tokland
requested changes
Jun 10, 2024
| // In DHIS 2.38.5 and above the defaults parameter is not working | ||
| // /api/metadata.json?fields=id&filter=id:eq:data_element_id&categoryCombo&defaults=INCLUDE/EXCLUDE; this is not working | ||
| // so manually removing the default categoryCombo | ||
| const elementWithoutDefaults = |
There was a problem hiding this comment.
A use case should not make any reference to DHIS2 (that's an implementation detail). If DHIS2 has a bug (Indeed, I've checked it: 2.36 OK, 2.38 FAIL), any extra processing should be done in the data layer, in the DHIS2 repository implementation (check any file which calls the API with that option defaults: boolean -> apart from the metadata repo, I've found also utils/synchronization.ts; check if more)
Note: checking dhis2-core, DefaultCategoryService.java, the models that have a default object are the 4 expected: category, categoryOption, categoryCombo, categoryOptionCombo.
tokland
approved these changes
Jun 11, 2024
src/utils/d2-utils.ts
Outdated
| @@ -22,3 +25,47 @@ export function getD2APiFromInstance(instance: Instance) { | |||
| */ | |||
| return new D2Api({ baseUrl: instance.url, auth: instance.auth, backend: "fetch" }); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Let's move the file to data/ so it's more CleanArch compliant.
tokland
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
In DHIS 2.38.6 the defaults parameter is not working in the
metadataendpoint/api/metadata.json?fields=id&filter=id:eq:data_element_id&categoryCombo&defaults=INCLUDE/EXCLUDE;so I'm manually removing the default
categoryCombofromdataElements/dataSets📹 Screenshots/Screen capture
🔥 Is there anything the reviewer should know to test it?
📑 Others
#8694rjjmk