Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get feedback config from app-config.json file #956

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

eperedo
Copy link
Contributor

@eperedo eperedo commented Jun 5, 2024

📌 References

📝 Implementation

  • Load feedback config and encriptionKey from /public/app-config.json
  • The appKey was being used as encriptionKey
  • Remove app-config.ts file

With these changes we keep the initial setup instructions from README.MD:
"File public/app-config.json must be created by duplicating public/app-config.template.json and filling in the encryptionKey."

📹 Screenshots/Screen capture

Executing Rule
MetaData-Synchronization_appconfig.webm

New Feedback component version
image

📑 Others

#8694r8crj

@eperedo eperedo requested a review from MiquelAdell June 5, 2024 15:13
@ifoche
Copy link
Member

ifoche commented Jun 5, 2024

Task linked: CU-8694r8crj Debug metadata sync 2.18.0

Copy link
Contributor

@MiquelAdell MiquelAdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working. Thanks @eperedo

@MiquelAdell MiquelAdell merged commit 3958996 into development Jun 6, 2024
1 check passed
@MiquelAdell MiquelAdell deleted the fix/encription-key branch June 6, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants