Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade markwon library #45

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Upgrade markwon library #45

merged 2 commits into from
Feb 15, 2021

Conversation

xurxodev
Copy link

@xurxodev xurxodev commented Dec 1, 2020

📌 References

⚙️ branches

app:
Origin: :fix/feedback_link_click Target: develop-psi
dhis2-android-SDK:
Origin: develop-eyeseetea
dhis2-rule-engine:
Origin: f8a22e9e20c048e0e6f667f4817f420b7eb01731

🎩 What is the goal?

Difficulty to open hyperlinks. Sometimes, you have to click multiple times before the app opens the URL.

📝 How is it being implemented?

I have not found any problem to click on links. I have tested on an emulator and a physical device.

Anyway, I have realized two actions:

  • I have upgraded the markwon library that renderer markdown feedback to the last version. It solves problems with links in tables.
  • I have increased the font size in markdown feedback to make it easier to click on links.

💥 How can it be tested?

Use case 1: - open feedback with links (RDQA Clone for example) and links should work

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

Copy link
Member

@ifoche ifoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @xurxodev

@ifoche ifoche merged commit 1993e76 into develop-psi Feb 15, 2021
@ifoche ifoche deleted the fix/feedback_link_click branch February 15, 2021 05:46
xurxodev pushed a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants