Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/client feedback #33

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Feature/client feedback #33

merged 2 commits into from
Oct 7, 2020

Conversation

xurxodev
Copy link

📌 References

⚙️ branches

app:
Origin: :feature/client_feedback Target: develop-psi
dhis2-android-SDK:
Origin: develop-eyeseetea
dhis2-rule-engine:
Origin: android_2.0.1

🎩 What is the goal?

The goal is to apply the feedback of the client after the last release:

  • Hide indicators icon and menu in the event screen for PSI flavor
  • Apply live updates of the toolbar according to the TitlePattern while making changes to the event

📝 How is it being implemented?

  • I have created a global const by flavor to set if indicators are visible in the event capture screen.
  • I have update EventCapture presenter and activity to realize live updates in the toolbar

💥 How can it be tested?

Use case 1: - the indicators icon and menu should not be visible in the event capture screen for the psi flavor
Use case 2: - changes in the event should realize live updates in the toolbar according to TitlePattern of the program stage

💾 Requires DB migration?

  • Nope, we can just merge this branch.
  • Yes, but we need to apply it before merging this branch.
  • Yes, it's already applied.

🎨 UI changes?

  • Nope, the UI remains as beautiful as it was before!
  • Yeap, here you have some screenshots-

Copy link
Member

@ifoche ifoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @xurxodev

@ifoche ifoche merged commit 8ce7c5e into develop-psi Oct 7, 2020
@ifoche ifoche deleted the feature/client_feedback branch October 7, 2020 10:44
xurxodev pushed a commit that referenced this pull request Jun 27, 2023
* Update HomeActivity.kt

* Adding managestockViewmodel as param to checkVisbility

* check  size of the data in the table

* Adding variables to check the table content

* Update paperwork.json

* Code style

* Update HomeScreen.kt

Co-authored-by: Andrés Miguel Rubio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants