Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Org Units filter #16

Merged
merged 3 commits into from
Jan 7, 2025
Merged

feat: Add Org Units filter #16

merged 3 commits into from
Jan 7, 2025

Conversation

MatiasArriola
Copy link
Contributor

📌 References

📝 Implementation

  • Added Organization Units Filter for visualizations
    • Using a TextField and a ConfirmationDialog, similar to user-extended-app filter implementation
  • Upgraded @eyeseetea/* and @dhis/* dependencies

🎨 Screenshots

image

@MatiasArriola
feat: Add Org Units filter
5eb79f7 
upgrade dependencies
eperedo
eperedo requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MatiasArriola, looks good, just some minor observations. Let me know if you have any questions

src/domain/entities/OrgUnit.ts Outdated Show resolved Hide resolved
src/data/repositories/OrgUnitD2Repository.ts Outdated Show resolved Hide resolved
src/domain/repositories/PluginVisualizationRepository.ts Show resolved Hide resolved
src/webapp/components/dashboard-filter/DashboardFilter.tsx Outdated Show resolved Hide resolved
src/webapp/components/org-units-filter/OrgUnitPicker.tsx Show resolved Hide resolved
src/webapp/hooks/useOrgUnitRoots.ts Outdated Show resolved Hide resolved
src/webapp/hooks/useOrgUnitRoots.ts Show resolved Hide resolved
@MatiasArriola
Copy link
Contributor Author

Thanks @eperedo! I've implemented the changes. As we discussed privately, I've kept the orgUnitIds. Anything else, let me know

@MatiasArriola MatiasArriola requested a review from eperedo January 7, 2025 13:40
eperedo
eperedo approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @MatiasArriola

@eperedo eperedo merged commit 8082b48 into feat/ntd-customizations Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eperedo eperedo eperedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatiasArriola @eperedo