-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: new visualization plugin #15
Feature: new visualization plugin #15
Conversation
Keep js plugins as LegacyPlugins Load Legacy Plugins conditionally Load Visualizations independently (new repo) Move eventReport and eventChart to eventVisualization
Check version to use legacy only for dhis < 39 Refactor and small Type changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MatiasArriola! It looks good, just a few minor changes in the code.
I was able to load almost every visualization but not this dashboard with eventReport (I understand we should use the legacy plugin for this one, right?)
https://play.im.dhis2.org/stable-2-41-2/dhis-web-dashboard/#/GNlS3sXJZFE
Thanks @eperedo ! I've implemented the corrections and I will keep them in mind for future changes. Regarding that particular dashboard, I believe I missed it because it wasn't there past week, and also most of my testing was done against the 2-40-6 instance. I don't understand why that dashboard doesn't return the If needed for legacy support, we could add back the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MatiasArriola, looks good to me.
You're right about the eventVisualization
I've tested in the test environment of the client that is working with the app and visualizations include the eventVisualization object. So let's keep your implementation.
📌 References
📝 Implementation
PluginVisualizationRepository
. Eachget
is performed individually instead of batching all the requests at the repository level.eventCharts
andeventReports
are unified intoeventVisualizations
, as per DHIS docs.🔥 Testing
eventVisualizations
endpoint.