Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some of tinie_snipah's changes to enable lore usage. Recommend additional testing before actually merging it. #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Pheenixm
Copy link

@Pheenixm Pheenixm commented Jan 5, 2013

Proved rather unstable in testing, but then again, I was using an unstable version. Had to modify net.minecraft.server references to net.mincraft.server.v1_4_5. Unsure if this is an issue. Prison pearls in testing "failed to validate" and player was freed. Unsure of cause of this.

In testing on my computer, proved unstable for some reason. Unknown
why, just is
@ttk2
Copy link

ttk2 commented Jan 5, 2013

The lore changes do not maintain the pearl index, without it PrisonPearl
can not find pearls and the system is totally useless.

On Fri, Jan 4, 2013 at 11:43 PM, Pheenixm [email protected] wrote:

Proved rather unstable in testing, but then again, I was using an unstable
version. Had to modify net.minecraft.server references to
net.mincraft.server.v1_4_5. Unsure if this is an issue. Prison pearls in

testing "failed to validate" and player was freed. Unsure of cause of this.

You can merge this Pull Request by running:

git pull https://github.com/Pheenixm/PrisonPearl master

Or view, comment on, or merge it at:

#14
Commit Summary

  • Added tinie_snipah's changes

File Changes

  • M .classpath (8)
  • M src/com/untamedears/PrisonPearl/PrisonPearlManager.java (23)
  • M src/com/untamedears/PrisonPearl/PrisonPearlPlugin.java (6)

Patch Links

@Pheenixm
Copy link
Author

Pheenixm commented Jan 7, 2013

Fixed the data value issue

@ttk2
Copy link

ttk2 commented Jan 7, 2013

How reliable is the method by which it transfers old pearls to the new
system?

On Sun, Jan 6, 2013 at 11:05 PM, Pheenixm [email protected] wrote:

Fixed the data value issue


Reply to this email directly or view it on GitHubhttps://github.com//pull/14#issuecomment-11940291.

@Pheenixm
Copy link
Author

Pheenixm commented Jan 7, 2013

Due to concerns about how reliable that might be, I opted to stick with the metadata system for the time being and introduce lore just to enhance the tooltip. I'll rewrite the system later once more pearls have lore

Ty4Code pushed a commit to Ty4Code/PrisonPearl that referenced this pull request Nov 17, 2014
Reduce logging output spam for imprisoned alts (Exultant#10).

Fix bug where expired PrisonPearls from unloaded chunks weren't remove
from task list.

Log coordinates of involved players during PrisonPearl capture/free'ing.
(Exultant#14)

Prevent imprisoned players from picking up Prison Pearls. (Exultant#12)
Ty4Code pushed a commit to Ty4Code/PrisonPearl that referenced this pull request Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants