Remove splitting ranges on emojis on the web #598
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2025
BartoszGrajdek
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
LGTM! 👍🏻
One problem I have is that it's not possible to use CMD + ➡️ when the cursor is in front of emoji. (not sure if that's a blocker cc @tomekzaw)
SR
Screen.Recording.2025-01-16.at.16.17.18.mov
| const sortedRanges = sortRanges(splittedRanges); | ||
| const groupedRanges = groupRanges(sortedRanges); | ||
|
|
||
| const groupedRanges = groupRanges(markdownRanges); |
There was a problem hiding this comment.
Maybe do the sorting again here.
There was a problem hiding this comment.
We don't need it here. Sorting influences only the web and since we blocked spitting ranges for this platform, the output will still be correctly sorted
shubham1206agra
approved these changes
Jan 16, 2025
tomekzaw
reviewed
Jan 16, 2025
| @@ -252,13 +252,16 @@ function parseExpensiMark(markdown: string): MarkdownRange[] { | |||
| ); | |||
| return []; | |||
| } | |||
| const sortedRanges = sortRanges(ranges); | |||
| let markdownRanges = sortedRanges; | |||
| if (Platform.OS === 'android') { | |||
There was a problem hiding this comment.
Since parseExpensiMark is a worklet, let's extract Platform.OS outside to avoid capturing whole Platform object in worklet closure.
const isAndroid = Platform.OS === 'android';
function parseExpensiMark(...) {
if (isAndroid) { /* ... */ }
}
tomekzaw
reviewed
Jan 16, 2025
Comment on lines
+255
to
+256
| const sortedRanges = sortRanges(ranges); | ||
| let markdownRanges = sortedRanges; |
There was a problem hiding this comment.
Suggested change
| const sortedRanges = sortRanges(ranges); | |
| let markdownRanges = sortedRanges; | |
| let markdownRanges = sortRanges(ranges); |
tomekzaw
reviewed
Jan 16, 2025
Comment on lines
+32
to
+33
| fontStyle: 'normal', | ||
| textDecoration: 'none', |
There was a problem hiding this comment.
Suggested change
| fontStyle: 'normal', | |
| textDecoration: 'none', | |
| fontStyle: 'normal', // remove italic | |
| textDecoration: 'none', // remove strikethrough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes the problem with triplicating syntaxes inside the Live Markdown Input, by removing range-splitting logic from the web platform and replacing it with the fix based on CSS styles. In the future, we will focus on fixing the web parser to support splitting emojis among all other styles (especially inline code block) and properly handle tag hierarchy edge cases when building HTML structure.
Related Issues
Expensify/App#55115
Manual Tests
_🥰 test 😇 test 🥹_# *~_🥰 test 😇 test 🥹_~*Linked PRs
#597