Added Manifest V3 compatibility for Firefox #197
Conversation
melvin-bot
bot
requested review from
youssef-lr
and removed request for
a team
There was a problem hiding this comment.
Also, https://stackoverflowteams.com/c/expensify/questions/7043/7044#7044 needs updated to use the new build command.
| "manifest_version": 3, | ||
|
|
||
| "name": "K2 for GitHub", | ||
| "version": "1.3.66", |
There was a problem hiding this comment.
I believe there are instructions in the README to update this version for every PR. Can you please update the instructions to include this manifest file too?
| "description": "A Chrome Extension for Kernel Schedule", | ||
| "private": true, | ||
| "scripts": { | ||
| "preinstall": "./tools/checkRuntimeVersions.sh", | ||
| "build": "webpack --progress --config webpack.prod.js", | ||
| "build:chrome": "webpack --progress --config webpack.prod.js --env platform=chrome", |
There was a problem hiding this comment.
Is the chrome build necessary? If so, let's be sure to update the README instructions for that too (and maybe remove the build command completely).
There was a problem hiding this comment.
it's not necessary, but my intention was to leave the default build command as it was, maintaining Chrome compatibility, add a new one for Firefox, and have build:chrome as an alias for build just for clarity
There was a problem hiding this comment.
Made a change to make it clearer that build is just an alias for build:chrome
There was a problem hiding this comment.
Ah, OK. I like the alias change. Thanks!
|
@youssef-lr I'm gonna go ahead and merge this |
|
@mjasikowski It's got a new error now:
The link points to: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json |
|
@tgolen nice, new error means progress! |
Added a separate build script for Firefox (
npm run build:firefox) that usesmanifest-firefox.jsoninstead of the defaultmanifest.json. Since FIrefox has no background worker support, we had to fall back to standard background script for that instead.Usage:
-
npm run buildornpm run build:chromebuilds the Chrome compatible version in dist-
npm run build:firefoxbuilds the Firefox compatible version in dist