Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with characters after @here mention #603

Merged

Conversation

Skalakid
Copy link
Contributor

Disabled writing @here mentions together with letters and numbers at the end. Now only punctuation characters are acceptable

Fixed Issues

$ Expensify/App#31180

Tests

  1. Open Expensify App
  2. Open chat
  3. Write "@herex" - it shouldn't be parsed into mention
  4. Write "@here!" - it should be parsed into mention like: @here!

QA

Same as tests

@Skalakid Skalakid requested a review from a team as a code owner November 14, 2023 09:03
@melvin-bot melvin-bot bot requested review from bondydaa and removed request for a team November 14, 2023 09:03
@Skalakid Skalakid changed the title fix bug with characters after @here mention Fix bug with characters after @here mention Nov 14, 2023
@bondydaa
Copy link
Contributor

@roryabraham do you want to review?

@bondydaa bondydaa merged commit 1b51807 into Expensify:main Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants