Add methods to create and update admin issued virtual cards #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
nkuoch
requested review from
MariaHCD and
lakchote
and removed request for
Gonals
MariaHCD
reviewed
Nov 6, 2023
lib/API.jsx
Outdated
| */ | ||
| editAdminIssuedVirtualCard: function (parameters) { | ||
| const commandName = 'Card_EditAdminIssuedVirtualCard'; | ||
| requireParameters(['domainName', 'cardID', 'cardName', 'assigneeEmail', 'cardLimit', 'cardLimitType'], parameters, commandName); |
There was a problem hiding this comment.
Suggested change
| requireParameters(['domainName', 'cardID', 'cardName', 'assigneeEmail', 'cardLimit', 'cardLimitType'], parameters, commandName); | |
| requireParameters(['domainName', 'cardID', 'cardTitle', 'assigneeEmail', 'cardLimit', 'cardLimitType'], parameters, commandName); |
Maybe we should standardize on using cardTitle instead of cardName for admin-issued virtual cards everywhere 🤔
There was a problem hiding this comment.
I think it would be a good idea to standardize, yes. I've found one spot where we're using cardName instead of cardTitle here
|
updated! |
lakchote
approved these changes
Nov 7, 2023
MariaHCD
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/304890
Tests
Tested in https://github.com/Expensify/Web-Expensify/pull/39483
QA
None