-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the issue that inconsistent highlighting occurs when multiple mentions are used without spaces #594
Merged
Merged
fix the issue that inconsistent highlighting occurs when multiple mentions are used without spaces #594
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6c0760a
fix-#21753
agilejune cd50eb3
update test case
agilejune 77c08a9
fix 21753 - edge cases of multiple mention
agilejune 378d8f0
Merge branch 'main' into fix-#21753
agilejune 2b7a23a
Merge branch 'Expensify:main' into fix-#21753
agilejune b5707f8
fix lint
agilejune 5d40ac3
remove condition
agilejune 1d6b926
Merge branch 'main' into fix-#21753
agilejune d5d7fcd
Merge branch 'Expensify:main' into fix-#21753
agilejune bdbef09
fix here mention
agilejune File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1298,6 +1298,36 @@ test('Test for @here mention without space or supported styling character', () = | |
expect(parser.replace(testString)).toBe(resultString); | ||
}); | ||
|
||
test('Test user mention and here mention, which are concatenated without space', () => { | ||
let testString = '@[email protected]@here'; | ||
let resultString = '<mention-user>@[email protected]</mention-user><mention-here>@here</mention-here>'; | ||
expect(parser.replace(testString)).toBe(resultString); | ||
|
||
testString = '@[email protected][email protected]'; | ||
resultString = '<mention-here>@here</mention-here><mention-user>@[email protected]</mention-user>'; | ||
expect(parser.replace(testString)).toBe(resultString); | ||
|
||
testString = '@[email protected]@[email protected]'; | ||
resultString = '<mention-user>@[email protected]</mention-user><mention-user>@[email protected]</mention-user>'; | ||
expect(parser.replace(testString)).toBe(resultString); | ||
|
||
testString = '@here@[email protected]'; | ||
resultString = '<mention-here>@here</mention-here><mention-user>@[email protected]</mention-user>'; | ||
expect(parser.replace(testString)).toBe(resultString); | ||
|
||
testString = '@[email protected]@here'; | ||
resultString = '<mention-user>@[email protected]</mention-user><mention-here>@here</mention-here>'; | ||
expect(parser.replace(testString)).toBe(resultString); | ||
|
||
testString = '@here@[email protected]'; | ||
resultString = '<mention-here>@here</mention-here><mention-user>@[email protected]</mention-user>'; | ||
expect(parser.replace(testString)).toBe(resultString); | ||
|
||
testString = '@[email protected]@here'; | ||
resultString = '<mention-user>@[email protected]</mention-user><mention-here>@here</mention-here>'; | ||
expect(parser.replace(testString)).toBe(resultString); | ||
}); | ||
|
||
test('Test for mention inside link and email markdown', () => { | ||
const testString = '[@[email protected]](expensify.com) ' | ||
+ '[_@[email protected]_](expensify.com) ' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use general emails, not mine 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's updated with general ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update Step 2 in Tests as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done as well