Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const MAX_TRIAL_BONUS_DAYS #587

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Add const MAX_TRIAL_BONUS_DAYS #587

merged 1 commit into from
Oct 12, 2023

Conversation

lakchote
Copy link
Contributor

@lakchote lakchote commented Oct 12, 2023 •
edited
Loading

Related issue

Fixed Issues

$ GH_LINK

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

Modified locally the CONST.jsx file in node_modules/expensify-common and ensured 42 was shown in the RHP for someone who has the NVP private_eligible50 set to true on a brand new account that clicked on Business in the first Inbox task.

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?
  • Support login into an account with private_eligible50 set to true
  • Click Business in the inbox task
  • The RHP should open and you should see the number 42

@lakchote lakchote self-assigned this Oct 12, 2023
@lakchote lakchote requested a review from a team as a code owner October 12, 2023 06:17
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from Li357 and removed request for a team October 12, 2023 06:18
@lakchote
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@lakchote lakchote requested review from AndrewGable and removed request for Li357 October 12, 2023 06:23
@AndrewGable AndrewGable merged commit 18bf903 into main Oct 12, 2023
5 checks passed
@AndrewGable AndrewGable deleted the lucien/add-const-dedicated-setup branch October 12, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

Assignees

@lakchote lakchote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lakchote @AndrewGable