Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match email rule with link rule #583

Merged
merged 4 commits into from
Oct 6, 2023
Merged

match email rule with link rule #583

merged 4 commits into from
Oct 6, 2023

Conversation

c3024
Copy link
Contributor

@c3024 c3024 commented Oct 5, 2023 •
edited
Loading

Fixed Issues

$ GH_LINK Expensify/App#28544
$ Proposal Expensify/App#28544 (comment)

Tests

  1. Go to any chat on New Expensify
  2. In the composer, type a message [emoji](email) (for example [😄]([email protected])) and send
  3. Verify that in the message sent, emoji is not changed to link

QA

  1. Go to any chat on New Expensify
  2. In the composer, type a message [emoji](email) (for example [😄]([email protected])) and send
  3. Verify that in the message sent, emoji is not changed to link
Result
commonWeb.mov

@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@c3024 c3024 marked this pull request as ready for review October 5, 2023 01:45
@c3024 c3024 requested a review from a team as a code owner October 5, 2023 01:45
@c3024
Copy link
Contributor Author

c3024 commented Oct 5, 2023

I have read the CLA Document and I hereby sign the CLA

@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team October 5, 2023 01:46
@c3024 c3024 mentioned this pull request Oct 5, 2023
Closed
6 tasks
@c3024
Copy link
Contributor Author

c3024 commented Oct 5, 2023

I have read the CLA Document and I hereby sign the CLA

@hoangzinh
Copy link

@c3024 could you please add unit tests to cover new changes? Thanks

@c3024
Copy link
Contributor Author

c3024 commented Oct 5, 2023

Done @hoangzinh . Thanks!

hoangzinh
hoangzinh approved these changes Oct 5, 2023
View reviewed changes
Copy link

@hoangzinh hoangzinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with various cases

Test case:

[😄]([email protected])
[😄]( [email protected])
[😄] [email protected]
[😄](([email protected]))
[😄[email protected]]([email protected])
[😄 [email protected] ]([email protected])

Before:
Screenshot 2023-10-05 at 15 37 21

After:
Screenshot 2023-10-05 at 15 37 00

@hoangzinh
Copy link

All is yours cc @tylerkaraszewski

@arosiclair arosiclair requested review from tylerkaraszewski and removed request for arosiclair October 5, 2023 09:27
@tylerkaraszewski
Copy link
Contributor

Why are the author and reviewer checklists missing on this PR?

@hoangzinh
Copy link

@c3024 I realize the linter is failed in this PR. Could you help to fix?

@hoangzinh
Copy link

@tylerkaraszewski this is our internal library, not our Expensify/App repo so there are no reviewer checklists here. We will have another PR to bump version of this internal library in Expensify/App repo, then we will have checklists there.

@c3024
Copy link
Contributor Author

c3024 commented Oct 6, 2023 •
edited
Loading

@hoangzinh Thanks. I fixed the lint error.

@tylerkaraszewski tylerkaraszewski merged commit 0c2c23d into Expensify:main Oct 6, 2023
5 checks passed
@c3024 c3024 mentioned this pull request Oct 11, 2023
Closed
59 tasks
@rayane-djouah rayane-djouah mentioned this pull request Jul 9, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangzinh hoangzinh hoangzinh approved these changes

@tylerkaraszewski tylerkaraszewski tylerkaraszewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c3024 @hoangzinh @tylerkaraszewski