Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace window-style newline with <br /> #560

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: replace window-style newline with <br /> #560

merged 1 commit into from
Jul 26, 2023

Conversation

s-alves10
Copy link
Contributor

Fixed Issues

$ Expensify/App#22890

Tests

Verified that windows-style newline(\r\n) is replaced with <br /> during the unit-tests

    Input: 'This sentence has a windows-style newline \r\n Yep just had one \r\n Oh there it is another one'
    Output: 'This sentence has a windows-style newline <br /> Yep just had one <br /> Oh there it is another one'

Also tested in the following steps

  1. Open any chat
  2. Copy any text on windows and paste it to the composer and send it
  3. Verify that new line doesn't appear and the text is sent as is

QA

  1. Open any chat
  2. Copy any text on windows and paste it to the composer and send it
  3. Verify that new line doesn't appear and the text is sent as is

@s-alves10 s-alves10 marked this pull request as ready for review July 26, 2023 08:10
@s-alves10 s-alves10 requested a review from a team as a code owner July 26, 2023 08:10
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team July 26, 2023 08:11
@s-alves10 s-alves10 mentioned this pull request Jul 26, 2023
Closed
6 tasks
rushatgabhane
rushatgabhane approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rushatgabhane
Copy link
Member

rushatgabhane commented Jul 26, 2023 •
edited
Loading

@Julesssss we can merge this!

@Julesssss Julesssss merged commit 98d8fea into Expensify:main Jul 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushatgabhane rushatgabhane rushatgabhane approved these changes

@Julesssss Julesssss Julesssss approved these changes

@cristipaval cristipaval Awaiting requested review from cristipaval

Assignees

@s-alves10 s-alves10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-alves10 @rushatgabhane @Julesssss @sangar-1028