make all email link variants return the same value

Expensify · Nov 15, 2023 · a09e11a · a09e11a
1 parent f3af425
commit a09e11a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/__tests__/ExpensiMark-HTML-test.js b/__tests__/ExpensiMark-HTML-test.js
@@ -843,8 +843,8 @@ test('Test markdown style email link with various styles', () => {
         + '<a href="mailto:[email protected]">Expensify Email</a>'
         + '<a href="mailto:[email protected]">[email protected]</a>'
         + '<a href="mailto:[email protected]">[email protected]</a>'
-        + '<a href="mailto:[email protected]">mailto:[email protected]</a>'
-        + '<a href="mailto:[email protected]">mailto:[email protected]</a>'
+        + '<a href="mailto:[email protected]">[email protected]</a>'
+        + '<a href="mailto:[email protected]">[email protected]</a>'
         + '<a href="mailto:[email protected]">[email protected]</a>'
         + '<a href="mailto:[email protected]">(Expensify)</a>'
         + '[Expensify <a href="mailto:[email protected]">Test</a> Test](<a href="mailto:[email protected]">[email protected]</a>)'

diff --git a/lib/ExpensiMark.js b/lib/ExpensiMark.js
@@ -68,7 +68,12 @@ export default class ExpensiMark {
                     if (g1.match(CONST.REG_EXP.EMOJIS) || !g1.trim()) {
                         return match;
                     }
-                    return `<a href="mailto:${g2}">${g1.trim()}</a>`;
+                    let label = g1.trim();
+                    const href = `mailto:${g2}`;
+                    if (label === href) {
+                        label = g2;
+                    }
+                    return `<a href="${href}">${label}</a>`;
                 },
             },