Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Console error cleanup: fix require cycle warnings (part 1) #52561

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[No QA] Console error cleanup: fix require cycle warnings (part 1) #52561

wants to merge 11 commits into from

Commits on Nov 14, 2024

  1. fix cycles related to CONST.ts

    @JKobrynski
    JKobrynski committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    86dbf16 View commit details
    Browse the repository at this point in the history

  2. fix require cycles starting with Log.ts -> Network/index.ts

    @JKobrynski
    JKobrynski committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    eddc1d2 View commit details
    Browse the repository at this point in the history

  3. fix require cycles starting with API/index.ts -> Middleware/index.ts … 

    …-> Reauthentication.ts -> Authentication.ts
    @JKobrynski
    JKobrynski committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    14a8253 View commit details
    Browse the repository at this point in the history

  4. Fix require cycles starting with Navigation.ts -> ReportConnection.ts… 

    … -> ... -> PolicyUtils.ts
    @JKobrynski
    JKobrynski committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    172e2df View commit details
    Browse the repository at this point in the history

  5. fix the ReportConnection.ts -> PriorityMode.ts -> ReportConnection.ts… 

    … require cycle
    @JKobrynski
    JKobrynski committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1cd0315 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. fix import cycles starting with (and containing) ReportConnection.ts … 

    …-> Report.ts -> ReportConnection.ts
    @JKobrynski
    JKobrynski committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8dc09af View commit details
    Browse the repository at this point in the history

  2. fix require cycles containing Navigation.ts -> reportUtils.ts -> ... … 

    …-> TransactionUtils/index.ts chain
    @JKobrynski
    JKobrynski committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d24daac View commit details
    Browse the repository at this point in the history

  3. fix the Navigation.ts -> ... -> saveLastRoute/index.ios.ts -> App.ts … 

    …-> Navigation.ts require cycle
    @JKobrynski
    JKobrynski committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    eb5a8ff View commit details
    Browse the repository at this point in the history

  4. fix require cycles containing IOU.ts -> FileUtils.ts chain

    @JKobrynski
    JKobrynski committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a103417 View commit details
    Browse the repository at this point in the history

  5. add missing comment to dynamic import

    @JKobrynski
    JKobrynski committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9d01ed0 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'main' into fixRequireCycleWarnings_part1

    @JKobrynski
    JKobrynski committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b9b3681 View commit details
    Browse the repository at this point in the history