Handle disabled case when computing menu item background color #51988

luacmartins · 2024-11-04T20:27:26Z

Explanation of Change

We should handle the disabled case when computing the menu item background color, since disabled items can't be selected nor focused. cc @nkdengineer @jjcoffee

Fixed Issues

$ #50779
$ #51984

Tests

Go to staging.new.expensify.com
Go to Search.
Tap on the filter icon.
Add any filter.
Tap Save search.
Tap on the dropdown.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

![Screenshot_1730751716](https://github.com/user-attachments/assets/e834d9e5-b30e-4c6d-a712-092b8b6da6c6)

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

![Screenshot 2024-11-04 at 1 28 47 PM](https://github.com/user-attachments/assets/ff0a339a-804c-425b-a473-f0b72fb64aaf)

MacOS: Desktop

melvin-bot · 2024-11-04T20:50:14Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-11-04T20:50:31Z

@nkdengineer @jjcoffee will you please review?

dubielzyk-expensify · 2024-11-05T01:11:35Z

Screenshots not working. Want a design review on this? Happy to have a look

jjcoffee · 2024-11-05T09:46:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-11-05_10.53.27.mp4

Android: mWeb Chrome

android-chrome-2024-11-05_10.55.35.mp4

iOS: Native

ios-app-2024-11-05_11.14.51.mp4

iOS: mWeb Safari

ios-safari-2024-11-05_11.16.02.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-11-05_10.43.40.mp4

MacOS: Desktop

desktop-app-2024-11-05_10.48.05.mp4

jjcoffee

LGTM!

Would appreciate if you could take a quick look at the code @nkdengineer 🙏

melvin-bot · 2024-11-05T10:20:04Z

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2024-11-05T10:20:07Z

@dubielzyk-expensify Some screenshots here if you want to take a look.

luacmartins · 2024-11-06T20:14:41Z

Gonna merge this once since it's approved.

OSBotify · 2024-11-06T20:24:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-07T13:09:35Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-11T18:15:11Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

rayane-djouah · 2024-11-15T23:22:59Z

src/styles/utils/index.ts

-    if (isSelected) {
+
+    if (isDisabled) {
+        backgroundColor = undefined;
+    } else if (isSelected) {


FYI, this caused the following issue: #52259
We need to check for isSelected before checking for isDisabled.
More details can be found in this proposal: #52259 (comment)

handle disabled case

64a39d6

luacmartins self-assigned this Nov 4, 2024

luacmartins added 3 commits November 4, 2024 13:30

fix lint

bac8c97

fix ts

af085d4

fix errors

5b8081d

luacmartins marked this pull request as ready for review November 4, 2024 20:50

luacmartins requested review from a team as code owners November 4, 2024 20:50

melvin-bot bot requested a review from jjcoffee November 4, 2024 20:50

melvin-bot bot removed the request for review from a team November 4, 2024 20:50

jjcoffee approved these changes Nov 5, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote November 5, 2024 10:20

lakchote approved these changes Nov 5, 2024

View reviewed changes

luacmartins merged commit 4e06de3 into main Nov 6, 2024
17 checks passed

luacmartins deleted the cmartins-fixBg branch November 6, 2024 20:14

github-actions bot mentioned this pull request Nov 7, 2024

Deploy Checklist: New Expensify 2024-11-07 #52178

Closed

60 tasks

MuaazArshad mentioned this pull request Nov 8, 2024

[Payment 2024-11-18] [$250] Expense - Disabled category when selected is not highlighted #52259

Open

8 tasks

This was referenced Nov 11, 2024

[C+ Checklist Needs Completion] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard #50779

Closed

[HOLD for payment 2024-11-18] mWeb - "Saved" header is also highlighted when saved search is selected #51984

Closed

rayane-djouah reviewed Nov 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle disabled case when computing menu item background color #51988

Handle disabled case when computing menu item background color #51988

luacmartins commented Nov 4, 2024 •

edited

Loading

melvin-bot bot commented Nov 4, 2024

luacmartins commented Nov 4, 2024

dubielzyk-expensify commented Nov 5, 2024

jjcoffee commented Nov 5, 2024 •

edited

Loading

jjcoffee left a comment

melvin-bot bot commented Nov 5, 2024

jjcoffee commented Nov 5, 2024

luacmartins commented Nov 6, 2024

OSBotify commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 11, 2024

rayane-djouah Nov 15, 2024

Handle disabled case when computing menu item background color #51988

Handle disabled case when computing menu item background color #51988

Conversation

luacmartins commented Nov 4, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 4, 2024

luacmartins commented Nov 4, 2024

dubielzyk-expensify commented Nov 5, 2024

jjcoffee commented Nov 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 5, 2024

jjcoffee commented Nov 5, 2024

luacmartins commented Nov 6, 2024

OSBotify commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 11, 2024

rayane-djouah Nov 15, 2024

Choose a reason for hiding this comment

luacmartins commented Nov 4, 2024 •

edited

Loading

jjcoffee commented Nov 5, 2024 •

edited

Loading