Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase table row and decrease table row gap #49904

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Increase table row and decrease table row gap #49904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c160730
Increase table row and decrease table row gap
abzokhattab Sep 29, 2024
4eb1f38
Merge remote-tracking branch 'origin/main' into increase-table-row-an…
abzokhattab Oct 3, 2024
a848bc8
Decrease gap to 8px in skeleton rows
abzokhattab Oct 3, 2024
517805d
changing workspace list gap to 8px
abzokhattab Oct 3, 2024
c3fda59
minor fix
abzokhattab Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/OptionsListSkeletonView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function OptionsListSkeletonView({shouldAnimate = true, shouldStyleAsTable = fal
return (
<ItemListSkeletonView
shouldAnimate={shouldAnimate}
itemViewStyle={shouldStyleAsTable && [styles.highlightBG, styles.mb3, styles.mh5, styles.br2]}
itemViewStyle={shouldStyleAsTable && [styles.highlightBG, styles.mb2, styles.mh5, styles.br2]}
gradientOpacityEnabled={gradientOpacityEnabled}
renderSkeletonItem={({itemIndex}) => {
const lineWidth = getLinedWidth(itemIndex);
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/ChatListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function ChatListItem<TItem extends ListItem>({
[styles.selectionListPressableItemWrapper, styles.textAlignLeft, item.isSelected && styles.activeComponentBG, isFocused && styles.sidebarLinkActive, item.cursorStyle],
]}
wrapperStyle={[styles.flexRow, styles.flex1, styles.justifyContentBetween, styles.userSelectNone]}
containerStyle={styles.mb3}
containerStyle={styles.mb2}
isFocused={isFocused}
isDisabled={isDisabled}
showTooltip={showTooltip}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/Search/ReportListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function ReportListItem<TItem extends ListItem>({
item={item}
pressableStyle={listItemPressableStyle}
wrapperStyle={[styles.flexRow, styles.flex1, styles.justifyContentBetween, styles.userSelectNone, styles.alignItemsCenter]}
containerStyle={[styles.mb3]}
containerStyle={[styles.mb2]}
isFocused={isFocused}
isDisabled={isDisabled}
showTooltip={showTooltip}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/Search/TransactionListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function TransactionListItem<TItem extends ListItem>({
item={item}
pressableStyle={listItemPressableStyle}
wrapperStyle={listItemWrapperStyle}
containerStyle={[styles.mb3]}
containerStyle={[styles.mb2]}
isFocused={isFocused}
isDisabled={isDisabled}
showTooltip={showTooltip}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/TableListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function TableListItem<TItem extends ListItem>({
item={item}
pressableStyle={[[styles.selectionListPressableItemWrapper, item.isSelected && styles.activeComponentBG, isFocused && styles.sidebarLinkActive, item.cursorStyle]]}
wrapperStyle={[styles.flexRow, styles.flex1, styles.justifyContentBetween, styles.userSelectNone, styles.alignItemsCenter]}
containerStyle={styles.mb3}
containerStyle={styles.mb2}
isFocused={isFocused}
isDisabled={isDisabled}
showTooltip={showTooltip}
Expand Down
4 changes: 2 additions & 2 deletions src/components/Skeletons/SearchRowSkeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function SearchRowSkeleton({shouldAnimate = true, fixedNumItems, gradientOpacity
<View style={[styles.flex1, containerStyle]}>
<ItemListSkeletonView
itemViewHeight={CONST.SEARCH_SKELETON_VIEW_ITEM_HEIGHT}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mh5]}
itemViewStyle={[styles.highlightBG, styles.mb2, styles.br3, styles.mh5]}
gradientOpacityEnabled={gradientOpacityEnabled}
shouldAnimate={shouldAnimate}
fixedNumItems={fixedNumItems}
Expand Down Expand Up @@ -126,7 +126,7 @@ function SearchRowSkeleton({shouldAnimate = true, fixedNumItems, gradientOpacity
shouldAnimate={shouldAnimate}
fixedNumItems={fixedNumItems}
gradientOpacityEnabled={gradientOpacityEnabled}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mh5]}
itemViewStyle={[styles.highlightBG, styles.mb2, styles.br3, styles.mh5]}
renderSkeletonItem={() => (
<>
<Rect
Expand Down
2 changes: 1 addition & 1 deletion src/components/Skeletons/TableRowSkeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function TableListItemSkeleton({shouldAnimate = true, fixedNumItems, gradientOpa
shouldAnimate={shouldAnimate}
fixedNumItems={fixedNumItems}
gradientOpacityEnabled={gradientOpacityEnabled}
itemViewStyle={[styles.highlightBG, styles.mb3, styles.br3, styles.mh5]}
itemViewStyle={[styles.highlightBG, styles.mb2, styles.br3, styles.mh5]}
renderSkeletonItem={() => (
<>
<Circle
Expand Down
4 changes: 2 additions & 2 deletions src/pages/workspace/WorkspacesListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ function WorkspacesListPage() {
errorRowStyles={styles.ph5}
onClose={item.dismissError}
errors={item.errors}
style={styles.mb3}
style={styles.mb2}
>
<PressableWithoutFeedback
role={CONST.ROLE.BUTTON}
Expand Down Expand Up @@ -220,7 +220,7 @@ function WorkspacesListPage() {
</OfflineWithFeedback>
);
},
[isLessThanMediumScreen, styles.mb3, styles.mh5, styles.ph5, styles.hoveredComponentBG, translate, styles.offlineFeedback.deleted, session?.accountID, session?.email],
[isLessThanMediumScreen, styles.mb2, styles.mh5, styles.ph5, styles.hoveredComponentBG, translate, styles.offlineFeedback.deleted, session?.accountID, session?.email],
);

const listHeaderComponent = useCallback(() => {
Expand Down
1 change: 1 addition & 0 deletions src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4696,6 +4696,7 @@ const styles = (theme: ThemeColors) =>
marginHorizontal: 20,
backgroundColor: theme.highlightBG,
borderRadius: 8,
minHeight: variables.optionRowHeight,
},

searchQueryListItemStyle: {
Expand Down
Loading