hide hold option for invoices #49875
Open
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I removed the hold option for invoices, as invoices cannot be on hold.
Fixed Issues
$ #47570
PROPOSAL: #47570 (comment)
Tests
That is make sure there is no hold option shown for the invoices in these two places.
Offline tests
QA Steps
That is make sure there is no hold option shown for the invoices in these two places.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
No hold option shown in these two places for invoices.Android: mWeb Chrome
No hold option shown in these two places for invoices.
iOS: Native
No hold option shown in these two places for invoices.
iOS: mWeb Safari
No hold option shown in these two places for invoices.
MacOS: Chrome / Safari
web.webm
MacOS: Desktop
desktop.webm