Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Opened offline attachment directed to conversation page on online #49832

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Fix Opened offline attachment directed to conversation page on online #49832

wants to merge 25 commits into from
+60 −63

Commits on Sep 23, 2024

  1. change attachment target to prevInitialPageRef when current viewed at… 

    …tachment replaced / deleted
    @wildan-m
    wildan-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    48af2f2 View commit details
    Browse the repository at this point in the history

  2. don't dismiss only when the prev attachment with the same initialPage… 

    … index is similar
    @wildan-m
    wildan-m committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6ece814 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/48173-dismiss-when-no-attachment-with-same-page-index
    @wildan-m
    wildan-m committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    19db64e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/48173-dismiss-when-no-attachment-with-same-page-index
    @wildan-m
    wildan-m committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    34ba2c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. remove unnecessary code

    @wildan-m
    wildan-m committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2f21ca5 View commit details
    Browse the repository at this point in the history

  2. adjust comment

    @wildan-m
    wildan-m committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    67c1f2b View commit details
    Browse the repository at this point in the history

  3. fix lint, replace deprecated withOnyx

    @wildan-m
    wildan-m committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f95d459 View commit details
    Browse the repository at this point in the history

  4. implement for native

    @wildan-m
    wildan-m committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    de935c4 View commit details
    Browse the repository at this point in the history

  5. lint fix, replace deprecate withOnyx

    @wildan-m
    wildan-m committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    ce69418 View commit details
    Browse the repository at this point in the history

  6. typecheck fix

    @wildan-m
    wildan-m committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    613d8f3 View commit details
    Browse the repository at this point in the history

  7. remove unused code

    @wildan-m
    wildan-m committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f458e85 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Update src/components/Attachments/AttachmentCarousel/index.tsx 

    Co-authored-by: Abdelhafidh Belalia <[email protected]>
    @wildan-m @s77rt
    wildan-m and s77rt committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    15ac1ed View commit details
    Browse the repository at this point in the history

  2. refactor

    @wildan-m
    wildan-m committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    b42d3cd View commit details
    Browse the repository at this point in the history

  3. refactor for native

    @wildan-m
    wildan-m committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    8ef2085 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/48173-dismiss-when-no-attachment-with-same-page-index
    @wildan-m
    wildan-m committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e30a878 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary comment

    @wildan-m
    wildan-m committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    ed960b1 View commit details
    Browse the repository at this point in the history

  3. access the array directly instead of checking -1 in index

    @wildan-m
    wildan-m committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    ca1e6d5 View commit details
    Browse the repository at this point in the history

  4. adjust comment position

    @wildan-m
    wildan-m committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4167773 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/48173-dismiss-when-no-attachment-with-same-page-index
    @wildan-m
    wildan-m committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6741ab6 View commit details
    Browse the repository at this point in the history

  2. resolve issue incorrect newIndex on onPageSelected event

    @wildan-m
    wildan-m committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3e2e8d4 View commit details
    Browse the repository at this point in the history

  3. refine comment

    @wildan-m
    wildan-m committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fbd028f View commit details
    Browse the repository at this point in the history

  4. refactor

    @wildan-m
    wildan-m committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9a844fa View commit details
    Browse the repository at this point in the history

  5. fix issue attachment briefly changed before dismiss

    @wildan-m
    wildan-m committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3c10da9 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'main' of https://github.com/wildan-m/App into wildan/fi… 

    …x/48173-dismiss-when-no-attachment-with-same-page-index
    @wildan-m
    wildan-m committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    aaea3ba View commit details
    Browse the repository at this point in the history

  2. Refactor

    @wildan-m
    wildan-m committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    04d8e9f View commit details
    Browse the repository at this point in the history