fix: card error not show and cannot dismiss in report fraud page #49292

dominictb · 2024-09-16T18:48:35Z

Details

Fixed Issues

$ #49010
PROPOSAL: #49010 (comment)

Tests

Precondition: Have a workspace with Expensify Card enabled

[Admin] Go to workspace settings > Expensify Card > Issue card
Assign a Virtual card to employee with $100 Smart Limit
[Employee] Go to Settings > Wallet (might need to refresh page)
Verify the card shows under Assigned cards
[Admin] Open the card
Update Card limit to $0
[Employee] Open the card
Press Report virtual card fraud > Deactivate Card

Verify an error shows above Deactivate Card button

Close the RHP
Dismiss the error under the card in Assigned cards

Verify the error and RBR next to Wallet are dismissed

[Admin] Open the card
Update Card limit to $10

Verify the error below the card can be closed

Refresh the page

Verify the error is not there anymore

Verify that no errors appear in the JS console

Offline tests

QA Steps

Note: See MacOS: Chrome / Safari recordings for full test steps.

Precondition: Have a workspace with Expensify Card enabled

[Admin] Go to workspace settings > Expensify Card > Issue card
Assign a Virtual card to employee with $100 Smart Limit
[Employee] Go to Settings > Wallet (might need to refresh page)
Verify the card shows under Assigned cards
[Admin] Open the card
Update Card limit to $0
[Employee] Open the card
Press Report virtual card fraud > Deactivate Card

Verify an error shows above Deactivate Card button

Close the RHP
Dismiss the error under the card in Assigned cards

Verify the error and RBR next to Wallet are dismissed

[Admin] Open the card
Update Card limit to $10

Verify the error below the card can be closed

Refresh the page

Verify the error is not there anymore

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-18.at.00.44.00.mov

Android: mWeb Chrome

Screen.Recording.2024-09-18.at.00.38.01.mov

iOS: Native

Screen.Recording.2024-09-18.at.00.31.08.mov

iOS: mWeb Safari

Screen.Recording.2024-09-18.at.00.32.40.mov

MacOS: Chrome / Safari

screen-recording-2024-09-18-at-001947_2YmlKm43.mp4

Screen.Recording.2024-10-03.at.11.30.25.mov

MacOS: Desktop

Screen.Recording.2024-09-18.at.00.34.01.mov

melvin-bot · 2024-09-17T17:44:52Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2024-09-17T17:46:43Z

@jayeshmangwani I cannot reproduce the exact error message in OP. I can only reproduce Auth RequestReplacementExpensifyCard returned an error following steps in PR description.

Whatever, I think the main problem here is that any BE errors do not show and cannot be dismissed. We need to fixed them regardless of the content of the error.

jayeshmangwani · 2024-09-18T12:53:11Z

I cannot reproduce the exact error message in OP. I can only reproduce Auth RequestReplacementExpensifyCard returned an error following steps in PR description.

Thanks for the thorough testing steps. I tested it by reproducing the Auth RequestReplacementExpensifyCard error.

jayeshmangwani · 2024-09-18T12:55:57Z

@dominictb Can we please fix the lint failing ?
Even though they're not caused by our changes, we've edited a page that uses deprecated code, so can we please fix those as well? For context, see here https://expensify.slack.com/archives/C01GTK53T8Q/p1726169039084589

jayeshmangwani · 2024-09-19T10:04:17Z

@dominictb friendly bump for this #49292 (comment)

dominictb · 2024-09-20T06:59:15Z

@jayeshmangwani I'm unsure if we should address the lint error in this PR, as the PaymentMethodList page contains a lot of logic. I don't feel confident that all test cases will be properly covered after fixing the lint issues.

I as mentioned here, do you think we should ignore the fix lint in this PR? @cead22

However, if there's some reason that doing so is unsafe or unreasonable, you can bring it up in slack and ask the Expensify reviewer to ignore the error and merge the PR anyways.

cead22 · 2024-09-20T12:26:03Z

Let's give it a try, this is my first review that involves the withOnyx migration, but looking at PaymentMethodList, it doesn't look that complex, and it has default values for the props.

For bankAccountList we can probably do something like let combinedPaymentMethods = PaymentUtils.formatPaymentMethods(isLoadingOnyxValue ? {} : (bankAccountList ?? {}), filteredCardList, styles);

For cardList we can probably do something like const assignedCards = Object.values(isLoadingOnyxValue ? {} : (cardList ?? {}))

For isLoadingPaymentMethods we can probably do something like isDisabled={isLoadingPaymentMethods || isFormOffline || isLoadingOnyxValue}

I imagine testing this component shouldn't be too hard. We can add a payment method or two and make sure the list displays correctly.

Please let me know if I'm overlooking omething

dominictb · 2024-09-24T04:16:41Z

@jayeshmangwani I updated PR. Please help review again.

jayeshmangwani · 2024-09-24T05:51:48Z

@dominictb Could you please merge the latest main branch and push it? The Tests are failing on the PR.

dominictb · 2024-09-24T07:28:25Z

@jayeshmangwani I merged main

jayeshmangwani · 2024-09-24T13:58:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mWeb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2024-09-25T11:53:44Z

src/pages/settings/Wallet/PaymentMethodList.tsx

@@ -399,7 +409,7 @@ function PaymentMethodList({
                            icon={Expensicons.CreditCard}
                            onPress={onPress}
                            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-                            isDisabled={isLoadingPaymentMethods || isFormOffline}
+                            isDisabled={isLoadingPaymentMethods || isFormOffline || isLoadingPaymentMethodsOnyx}


@dominictb Why do we need isLoadingPaymentMethodsOnyx? isLoadingPaymentMethods should do the work here, right or am i missing something?

@dominictb Same thing for the isLoadingCardList and isLoadingBankAccountList, do we really need that?

Why do we need isLoadingPaymentMethodsOnyx? isLoadingPaymentMethods should do the work here, right or am i missing something?

The || isLoadingPaymentMethodsOnyx was added in this commit to remove withOnyx. Previously, when using withOnyx, isLoadingPaymentMethods had a default value of true. So, when switching to useOnyx, we needed to include || isLoadingPaymentMethodsOnyx wherever isLoadingPaymentMethods is used to ensure everything continues to function correctly

The same approach should be applied in the case isLoadingCardList and isLoadingBankAccountList. When using withOnyx, isLoadingCardList has default value is {}. So we need to use const assignedCards = Object.values(isLoadingCardList ? {} : cardList ?? {}).

Thanks for the details @dominictb.

I noticed an issue on the Expensify cards page within the workspaces—pressing the close icon doesn’t clear the error message. Although it's not related to the current issue but we had fixed a similar problem here in this PR.so, Just to confirm, @dominictb @cead22 should we address it as part of this task, or create a separate bug for it?

card-error-doesnt-go-away.mov

Hi! Coming in here as assigned - if it's going to be a pretty similar solution let's knock it out in this PR as well. I realize it's a different page but still card-related error I guess, and if we already have done the work we need to adjust, let's do it.

Great, Let's do this.

@dominictb We need to add the onClose here and set the errors null like we do in the clearDeletePaymentMethodError

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx

Lines 77 to 78 in 00cec11

<OfflineWithFeedback

key={`${item.nameValuePairs?.cardTitle}_${index}`}

Onyx.merge(paymentListKey, { [paymentMethodID]: { pendingAction: null, errors: null, }, });

jayeshmangwani

Changes work well. I've added a comment regarding the unrelated bug here: #49292 (comment)

jayeshmangwani · 2024-09-30T17:38:23Z

@dominictb Please merge the main branch and resolve any conflicts. I've bumped this on Slack to get someone from the internal team assigned, since @cead22 is OOO.

…/49010

…o fix/49010

dominictb · 2024-10-01T04:39:52Z

@jayeshmangwani Done.

…/49010

dominictb · 2024-10-02T09:28:15Z

@jayeshmangwani Done and retested well. Please retest on your side.

jayeshmangwani · 2024-10-02T10:02:41Z

Done and retested well

@dominictb Are you sure, you have tested and works well ??

jayeshmangwani · 2024-10-02T10:03:13Z

For me its not working

jayeshmangwani · 2024-10-02T10:03:39Z

Please upload a video, so that I can confirm

jayeshmangwani · 2024-10-02T10:06:37Z

@dominictb Don't you think you've passed the wrong key here? You've passed ONYXKEYS.CARD_LIST, but it should be ${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}, right?

Please correct me if I am wrong

…/49010

dominictb · 2024-10-03T04:34:53Z

@jayeshmangwani My bad I pushed the wrong code changes. I updated the code, test steps and added video:

Screen.Recording.2024-10-03.at.11.30.25.mov

jayeshmangwani · 2024-10-03T05:22:34Z

@dangrous code looks good and is ready for your approval

jayeshmangwani · 2024-10-07T06:01:01Z

@dangrous Whenever you can, please check the PR. It looks good to me.

dangrous · 2024-10-07T16:44:14Z

Thanks for your patience, I was OOO - this looks good to me!

OSBotify · 2024-10-07T16:54:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-07T22:28:36Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.46-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

github-actions · 2024-10-09T20:28:25Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dominictb added 2 commits September 17, 2024 01:42

fix: error not show and cannot dismiss in report fraud page

945786e

remove cardID for indismissable cards

5aa1fe5

dominictb marked this pull request as ready for review September 17, 2024 17:44

dominictb requested a review from a team as a code owner September 17, 2024 17:44

melvin-bot bot requested review from jayeshmangwani and removed request for a team September 17, 2024 17:44

dominictb added 3 commits September 23, 2024 10:16

merge main

a0cd296

fix: remove withOnyx

09a0dc2

fix: lint

9946fdb

Merge branch 'Expensify:main' into fix/49010

c546e1b

jayeshmangwani reviewed Sep 25, 2024

View reviewed changes

jayeshmangwani approved these changes Sep 26, 2024

View reviewed changes

melvin-bot bot requested a review from cead22 September 26, 2024 08:40

dominictb added 2 commits October 1, 2024 11:32

Merge branch 'main' of https://github.com/dominictb/epsf-app into fix…

1959b4f

…/49010

Merge branch 'fix/49010' of https://github.com/dominictb/epsf-app int…

2790961

…o fix/49010

jayeshmangwani approved these changes Oct 1, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous October 1, 2024 08:39

jayeshmangwani mentioned this pull request Oct 1, 2024

Close (X) button is not functioning for workspace card error messages. #50010

Closed

6 tasks

dominictb added 2 commits October 2, 2024 15:15

Merge branch 'main' of https://github.com/dominictb/epsf-app into fix…

c2be89c

…/49010

close error in workspace card list page

9cdd0ec

dominictb added 2 commits October 3, 2024 11:14

Merge branch 'main' of https://github.com/dominictb/epsf-app into fix…

55021de

…/49010

clear card error in workspace expensify card page

3722997

dangrous approved these changes Oct 7, 2024

View reviewed changes

dangrous merged commit b6f220d into Expensify:main Oct 7, 2024
18 checks passed

This was referenced Oct 7, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Build apk from delta ref / Build Android app #50344

Closed

Deploy Checklist: New Expensify 2024-10-07 #50366

Closed

melvin-bot bot mentioned this pull request Oct 9, 2024

[HOLD for payment 2024-10-16] [$250] Expensify Card - On report fraud page, error does not redirect and can not be closed #49010

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: card error not show and cannot dismiss in report fraud page #49292

fix: card error not show and cannot dismiss in report fraud page #49292

dominictb commented Sep 16, 2024 •

edited

Loading

melvin-bot bot commented Sep 17, 2024

dominictb commented Sep 17, 2024 •

edited

Loading

jayeshmangwani commented Sep 18, 2024

jayeshmangwani commented Sep 18, 2024

jayeshmangwani commented Sep 19, 2024

dominictb commented Sep 20, 2024

cead22 commented Sep 20, 2024 •

edited

Loading

dominictb commented Sep 24, 2024

jayeshmangwani commented Sep 24, 2024

dominictb commented Sep 24, 2024

jayeshmangwani commented Sep 24, 2024 •

edited

Loading

jayeshmangwani Sep 25, 2024

jayeshmangwani Sep 25, 2024

dominictb Sep 26, 2024

dominictb Sep 26, 2024

jayeshmangwani Sep 26, 2024

dangrous Oct 1, 2024

jayeshmangwani Oct 1, 2024

jayeshmangwani left a comment

jayeshmangwani commented Sep 30, 2024

dominictb commented Oct 1, 2024

dominictb commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

dominictb commented Oct 3, 2024

jayeshmangwani commented Oct 3, 2024

jayeshmangwani commented Oct 7, 2024

dangrous commented Oct 7, 2024

OSBotify commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 9, 2024

	<OfflineWithFeedback
	key={`${item.nameValuePairs?.cardTitle}_${index}`}

fix: card error not show and cannot dismiss in report fraud page #49292

fix: card error not show and cannot dismiss in report fraud page #49292

Conversation

dominictb commented Sep 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 17, 2024

dominictb commented Sep 17, 2024 • edited Loading

jayeshmangwani commented Sep 18, 2024

jayeshmangwani commented Sep 18, 2024

jayeshmangwani commented Sep 19, 2024

dominictb commented Sep 20, 2024

cead22 commented Sep 20, 2024 • edited Loading

dominictb commented Sep 24, 2024

jayeshmangwani commented Sep 24, 2024

dominictb commented Sep 24, 2024

jayeshmangwani commented Sep 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jayeshmangwani Sep 25, 2024

Choose a reason for hiding this comment

jayeshmangwani Sep 25, 2024

Choose a reason for hiding this comment

dominictb Sep 26, 2024

Choose a reason for hiding this comment

dominictb Sep 26, 2024

Choose a reason for hiding this comment

jayeshmangwani Sep 26, 2024

Choose a reason for hiding this comment

dangrous Oct 1, 2024

Choose a reason for hiding this comment

jayeshmangwani Oct 1, 2024

Choose a reason for hiding this comment

jayeshmangwani left a comment

Choose a reason for hiding this comment

jayeshmangwani commented Sep 30, 2024

dominictb commented Oct 1, 2024

dominictb commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

jayeshmangwani commented Oct 2, 2024

dominictb commented Oct 3, 2024

jayeshmangwani commented Oct 3, 2024

jayeshmangwani commented Oct 7, 2024

dangrous commented Oct 7, 2024

OSBotify commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 9, 2024

dominictb commented Sep 16, 2024 •

edited

Loading

dominictb commented Sep 17, 2024 •

edited

Loading

cead22 commented Sep 20, 2024 •

edited

Loading

jayeshmangwani commented Sep 24, 2024 •

edited

Loading