-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add employee and accounting page to onboarding flow #49161
Merged
Merged
Changes from 36 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
accc8a1
feat: add employee and accounting page to onboarding flow
nkdengineer 419f7cc
fix ts error
nkdengineer 88dda39
Merge branch 'main' into fix/48745
nkdengineer 6bdf7ed
add OnboadingListItem
nkdengineer e0bc748
fix test
nkdengineer de74800
add offline indicator and fix ts bug
nkdengineer 5f75726
Merge branch 'main' into fix/48745
nkdengineer a37009d
fix the font-size issue
nkdengineer d72dec2
decrease spacing between title and description
nkdengineer 2200305
Merge branch 'main' into fix/48745
nkdengineer 646fc6d
Update src/pages/OnboardingEmployees/index.tsx
nkdengineer b7b016f
Update src/pages/OnboardingAccounting/index.tsx
nkdengineer 6964f34
call completeOnboarding API
nkdengineer def4389
fix ts error
nkdengineer b923dab
Merge branch 'main' into fix/48745
nkdengineer b1e8c24
move the type to CONST
nkdengineer f8ff1f5
remove OnboardingListItem
nkdengineer a773766
remove onboardingIcon type
nkdengineer a50ce47
remove unused style
nkdengineer c9b6a0b
fix lint
nkdengineer 0d6adac
merge main
nkdengineer 13f4da9
add type and refactor style
nkdengineer 944b3d3
Merge branch 'main' into fix/48745
nkdengineer 1a67914
change firstname and lastname as optional
nkdengineer 497a35e
migrate to useOnyx
nkdengineer ced0874
remove withOnyx
nkdengineer 41de3e1
Merge branch 'main' into fix/48745
nkdengineer d417b6a
remove unnecessary code
nkdengineer c6c8cbc
Update src/SCREENS.ts
nkdengineer 11f3a4a
Merge branch 'main' into fix/48745
nkdengineer 465ffbc
Update src/CONST.ts
nkdengineer d3121d6
Update src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx
nkdengineer f72f134
refactor code
nkdengineer 076d4af
Merge branch 'fix/48745' of https://github.com/nkdengineer/App into f…
nkdengineer ccfa4e1
fix type error
nkdengineer a1201d2
remove unnecessary prop
nkdengineer 91bbbaf
Merge branch 'main' into fix/48745
nkdengineer 63a5932
remove unused style
nkdengineer 34f74ad
fix lint
nkdengineer fb70a3f
add style prop for list item
nkdengineer bdf3a08
Merge branch 'main' into fix/48745
nkdengineer d0be895
remove unnecessary prop
nkdengineer 5e61daf
add pl8 and pr8 style
nkdengineer d8b71b0
Merge branch 'main' into fix/48745
nkdengineer 0057cb1
resolve conflict
nkdengineer 939c169
merge main
nkdengineer 97e41e8
fix ts error
nkdengineer 556b83f
merge main
nkdengineer fe9d9b5
remove description translation
nkdengineer 9a1c414
Merge branch 'main' into fix/48745
nkdengineer 8706f60
update translation
nkdengineer 74631ed
Merge branch 'main' into fix/48745
nkdengineer 4516b4d
update confirm button to continue button
nkdengineer aab3ad8
fix ts error
nkdengineer 9985e88
remove unused variable
nkdengineer 7bba26c
Merge branch 'main' into fix/48745
nkdengineer 7fb12f0
remove onboaring work
nkdengineer 433261c
merge main
nkdengineer f806fde
remove import type
nkdengineer 3584504
merge main
nkdengineer bd6b524
merge main
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcaaron Should we confirm these copies on this PR or will complete on the next PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already confirmed. We need translations though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkdengineer Please ask in Slack for the translations