-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main tag shows Required status when all subtags are disabled #48738
Conversation
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@marcaaron I'll take this as C+ reviewer coming from #47818 👍 |
Sounds good. Thanks for stepping up! 🙇 |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.webmAndroid: mWeb Chromeandroid-mweb.webmiOS: Nativeios.mp4iOS: mWeb Safariios-mweb.mp4MacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
@Shahidullah-Muffakir Changes look good and the fix tests well.
I noticed you ✅ the box in your checklist but did not actually add the videos, therefore I had to leave the following checkbox on my checklist unchecked:
Once you actually complete your checklist, I will be able to complete mine and 🟢 Approve. Note I know that you might've not been able to test the changes at the time when the PR was opened because of issue #48675, which was fixed in PR #48723 and merged. You should be able to test and take videos once you sync this PR with the main branch since the fix is on main (that's how I was able to test). |
@ikevin127 Thank you, I'll merge the main and get the screenshots and videos added soon. |
@ikevin127 I've added videos for all supported devices to the OP. let me know if anything else is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding the test vids.
🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #48766. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Details
Fixed Issues
$48683
PROPOSAL:
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
androidNativesep.mov
Android: mWeb Chrome
andriodWebsep8.mov
iOS: Native
iosNative.mp4
iOS: mWeb Safari
iosWebsep.mp4
MacOS: Chrome / Safari
safarisep8.mp4
MacOS: Desktop
desktop.mov