-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : Accounting-App proceeds to Netsuite Setup when trying to connect to Sage Intacct #48698
Conversation
…t to Sage Intacct
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.mp4android-2.mp4Android: mWeb Chromeandroid-chrome.mp4iOS: Nativeios.mp4iOS: mWeb Safariios-safari.mp4MacOS: Chrome / Safarisafari.mp4MacOS: Desktopmac-desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was our mistake after resolving conflicts and calling the incorrect function. This change updates the function to the correct one.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Fix : Accounting-App proceeds to Netsuite Setup when trying to connect to Sage Intacct (cherry picked from commit 7dc2515) (CP triggered by roryabraham)
Details
Fixed Issues
$ #48686
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
A. NetSuite
B. Sage Intacct
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Fix-Show-warning-modal-on-POLICY_ACCOUNTING-after-workspace-upgrade-by-nyomanjyotisa-.-Pull-Request-48419-.-Expensify-App.mp4
New-Expensify-Native-Android.mp4
Android: mWeb Chrome
New-Expensify-Chrome-Android.mp4
New-Expensify-Chrome-Android.mp4
iOS: Native
New-Expensify-Native-iOS.mp4
New-Expensify-Native-iOS.mp4
iOS: mWeb Safari
New-Expensify-Safari-iOS.mp4
New-Expensify-Safari-iOS.mp4
MacOS: Chrome / Safari
-10-New-Expensify.mp4
New-Expensify-Chrome-MacOS.mp4
MacOS: Desktop
New-Expensify-Desktop.mp4
New-Expensify-Desktop.mp4