-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(47399) - Redirect to proper place after upgrade #47593
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Checking now |
Nit: @allroundexperts I don't this test steps is correct, shouldn't it be
And in the screenshots as well, we don't have tests done for Tags although we have Tag GL updation redirect as well. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-08-26.at.12.29.31.AM.movAndroid: mWeb ChromeScreen.Recording.2024-08-26.at.12.33.55.AM.moviOS: NativeScreen.Recording.2024-08-26.at.12.17.05.AM.movScreen.Recording.2024-08-26.at.12.17.34.AM.moviOS: mWeb SafariScreen.Recording.2024-08-26.at.12.25.14.AM.movMacOS: Chrome / SafariScreen.Recording.2024-08-26.at.12.10.42.AM.movScreen.Recording.2024-08-26.at.12.45.51.AM.movMacOS: DesktopScreen.Recording.2024-08-26.at.12.13.53.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @youssef-lr
🎀 👀 🎀
C+ Reviewed
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.25-0 🚀
|
Details
This PR fixes the incorrect redirect after GL and Payroll codes are saved.
Fixed Issues
$ #47399
PROPOSAL: N/A
Tests
Verify that saving GL & payroll code must be directed to specific category page.
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-17.at.4.26.50.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-08-17.at.4.26.21.AM.mov
iOS: Native
Screen.Recording.2024-08-17.at.4.25.35.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-08-17.at.4.24.50.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-17.at.4.21.07.AM.mov
MacOS: Desktop
Screen.Recording.2024-08-17.at.4.23.38.AM.mov