-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support image pasting on Native (2) #47203
Conversation
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: Nativea.mp4Android: mWeb Chromeaw.mp4iOS: Native20240811140915166.mp4iOS: mWeb Safariiw.mp4MacOS: Chrome / Safariw.mp4MacOS: Desktopd.mp4 |
Tested on simulator and it LGTM! @ishpaul777, Once you test/review #47065, you can approve the PR to assign the internal developer. |
ios build in progress might take few minutes |
Feature works great, Tested with copying from google, safari, chrome on mobile trim.DB52912C-B773-49B7-9E25-DD767660B0CC.MOVOnly time it does not work is when i copied from google doc on mac and try pasting on device (does not work for telegram also, works on notes app) trim.55F09C7C-82B4-4A57-A5CE-652AB92A78A7.MOV |
I am curious if we should also be able to support pasting image in private notes input like we do on Web, would be nice to have Screen.Recording.2024-08-12.at.8.52.20.PM.mov |
@ahmedGaber93 @ishpaul777 Thanks for testing. This seems working as expected for now. Can you please approve the PR?
This is a "nice to have" feature. I think can be handled separately if needed. Let's not block on this.
Same ^ except I'm not totally sure about inlined image support. I would say this is a low priority. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Probably a false positive. This only adds code execution when the user performs the paste action. Opening a page (rendering components) shouldn't be affected |
Note: This PR probably hasn't introduced the recession. The regression has been introduced at an earlier point, and the CI system will report any PR that follows this faulty PR as a regression. |
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.20-0 🚀
|
FYI I believe this was deployed to prod yesterday, from this checklist - #47356 |
@Beamanator doing the job your @OSBotify, Where are you |
Hahahah botify is a bit sick - being taken care of in #47461 |
get better soon Botify : ) |
@ahmedGaber93 Please reply in https://expensify.slack.com/archives/C02NK2DQWUX/p1723975573797779 I'd need some help debugging the code as I can't reproduce the bug from my end |
Details
TextInput
is having a new callbackonPaste
(facebook/react-native#45425) which is invoked when the user performs the paste action. The callback event contains the clipboard data. If files are found in the clipboard, upload them.Second attempt of #45722
Fixed Issues
$ #41239
PROPOSAL: #41239 (comment)
Tests
Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
mweb-chrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
mweb-safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov