[NoQA] e2e: handle process id has changed #46279

kirillzyusko · 2024-07-26T11:32:24Z

Details

I discovered several problems with current implementation:

When test fails we allow up to 3 failures per test suit. However when test fails, we don't stop profiler and we don't remove testDoneListener. As a result when we kill the app and start it again the PID gets changed and we get a warning + we have already two listeners for a test (old one that we haven't removed and a new one, that was attached for a new test). When new test will be finished we'll call .stop() two times and it'll lead to additional error. To fix that I added MesureUtils.stop() in onError + added clearAllDoneListeners.
Second problem can be related to a random crash of the application - sometimes it can crash on first run and we treat it as unrelialble test and fail test execution (without waiting for 3 errors). I decided to make it more stable and when we receive onPidChanged, then we reset current timeout timer, wait a little bit and re-run test.

Fixed Issues

$ #46129
PROPOSAL: N/A

Tests

run e2e pipeline and be sure there is no random crashes anymore

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-26T11:34:35Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kirillzyusko · 2024-07-26T11:34:46Z

@hannojg would you mind to have a look on that?

hannojg

LGTM, only some none blocking comments

hannojg · 2024-07-26T11:51:14Z

patches/@perf-profiler+android+0.13.0+001+pid-changed.patch

+       onStartMeasuring = () => {
+         // noop by default
+       },
+      onPidChanged = () => {},


do we have a upstream PR for that?

@hannojg not yet. I'd like to test how stable this fix will be in Expensify codebase and if it's pretty stable, then I'll create upstream PR

tests/e2e/utils/measure.ts

mkhutornyi · 2024-07-30T05:35:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

mkhutornyi

LGTM2

dangrous

Cool! This makes sense. What's the best way to confirm this is working once merged? just, uh, make sure we're not getting those errors anymore?

OSBotify · 2024-07-30T15:32:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-31T19:32:21Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-02T02:20:31Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

e2e: handle process id has changed

4d2ca3b

kirillzyusko changed the title ~~e2e: handle process id has changed~~ [NoQA] e2e: handle process id has changed Jul 26, 2024

kirillzyusko marked this pull request as ready for review July 26, 2024 11:34

kirillzyusko requested a review from a team as a code owner July 26, 2024 11:34

melvin-bot bot requested review from mkhutornyi and removed request for a team July 26, 2024 11:34

kirillzyusko mentioned this pull request Jul 26, 2024

[$250] [HOLD for payment 2024-08-09] Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #46129

Closed

hannojg approved these changes Jul 26, 2024

View reviewed changes

fix: extract types

7c6d987

mkhutornyi approved these changes Jul 30, 2024

View reviewed changes

melvin-bot bot requested a review from dangrous July 30, 2024 05:36

dangrous approved these changes Jul 30, 2024

View reviewed changes

dangrous merged commit d5effdc into Expensify:main Jul 30, 2024
16 checks passed

github-actions bot mentioned this pull request Jul 31, 2024

Deploy Checklist: New Expensify 2024-07-31 #46607

Closed

kirillzyusko mentioned this pull request Aug 1, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #46402

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] e2e: handle process id has changed #46279

[NoQA] e2e: handle process id has changed #46279

kirillzyusko commented Jul 26, 2024 •

edited

Loading

melvin-bot bot commented Jul 26, 2024

kirillzyusko commented Jul 26, 2024

hannojg left a comment

hannojg Jul 26, 2024

kirillzyusko Jul 26, 2024

mkhutornyi commented Jul 30, 2024

mkhutornyi left a comment

dangrous left a comment

OSBotify commented Jul 30, 2024

OSBotify commented Jul 31, 2024

OSBotify commented Aug 2, 2024

[NoQA] e2e: handle process id has changed #46279

[NoQA] e2e: handle process id has changed #46279

Conversation

kirillzyusko commented Jul 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 26, 2024

kirillzyusko commented Jul 26, 2024

hannojg left a comment

Choose a reason for hiding this comment

hannojg Jul 26, 2024

Choose a reason for hiding this comment

kirillzyusko Jul 26, 2024

Choose a reason for hiding this comment

mkhutornyi commented Jul 30, 2024

Reviewer Checklist

Screenshots/Videos

mkhutornyi left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 30, 2024

OSBotify commented Jul 31, 2024

OSBotify commented Aug 2, 2024

kirillzyusko commented Jul 26, 2024 •

edited

Loading