[NoQA] e2e: support for different units #43890

kirillzyusko · 2024-06-18T08:46:21Z

Details

Follow up PR for #43482 In this PR I'm adding different units for different types of measurement.

Caution

Highly desirable to merge this PR straight before a new release, since it contains pretty a lot of breaking changes and old .apks will be incompatible with new test runner. Should be merged after #43482

Before	After

Below you can find an example of generated markdown:

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start nativeLaunchEnd_To_appCreationStart	83.375 ms
App start nativeLaunch	89.375 ms
App start appCreation	90.125 ms
App start appCreationEnd_To_contentAppeared	647.875 ms
App start contentAppeared_To_screenTTI	1267.619 ms
App start runJsBundle	477.125 ms
App start TTI	2178.369 ms
App start regularAppStart	0.025 ms
App start time (CPU)	156.901 %
App start time (FPS)	59.784 FPS
App start time (RAM)	356.692 MB

Show details

Name	Duration
App start nativeLaunchEnd_To_appCreationStart	Baseline Mean: 100.750 ms Stdev: 56.740 ms (56.3%) Runs: 59 67 72 78 85 90 109 246 Current Mean: 83.375 ms Stdev: 11.916 ms (14.3%) Runs: 60 79 80 81 83 84 100 100
App start nativeLaunch	Baseline Mean: 85.375 ms Stdev: 4.794 ms (5.6%) Runs: 78 80 83 85 86 88 89 94 Current Mean: 89.375 ms Stdev: 10.012 ms (11.2%) Runs: 77 79 87 88 89 89 94 112
App start appCreation	Baseline Mean: 97.875 ms Stdev: 16.922 ms (17.3%) Runs: 67 90 90 94 96 108 109 129 Current Mean: 90.125 ms Stdev: 12.634 ms (14.0%) Runs: 74 83 84 85 91 91 93 120
App start appCreationEnd_To_contentAppeared	Baseline Mean: 622.125 ms Stdev: 49.798 ms (8.0%) Runs: 562 577 590 592 635 636 661 724 Current Mean: 647.875 ms Stdev: 61.310 ms (9.5%) Runs: 568 592 601 606 657 694 726 739
App start contentAppeared_To_screenTTI	Baseline Mean: 1305.782 ms Stdev: 133.131 ms (10.2%) Runs: 1156.5970499999821 1187.303460999974 1206.6081209999975 1241.2006399999955 1265.4872229999746 1362.3920100000105 1497.405487000011 1529.264254000038 Current Mean: 1267.619 ms Stdev: 105.689 ms (8.3%) Runs: 1140.6160490000038 1201.7801089999848 1205.4019809999736 1207.8677119999775 1233.2525310000055 1293.425217000011 1368.7890729999635 1489.8198379999958
App start runJsBundle	Baseline Mean: 460.250 ms Stdev: 32.771 ms (7.1%) Runs: 430 439 441 442 452 454 489 535 Current Mean: 477.125 ms Stdev: 55.379 ms (11.6%) Runs: 408 422 422 462 474 528 544 557
App start TTI	Baseline Mean: 2211.907 ms Stdev: 211.166 ms (9.5%) Runs: 2002.5970499999821 2092.4872229999746 2093.2006399999955 2119.303460999974 2126.6081209999975 2161.3920100000105 2412.405487000011 2687.264254000038 Current Mean: 2178.369 ms Stdev: 167.123 ms (7.7%) Runs: 2005.6160490000038 2038.8677119999775 2039.7801089999848 2054.4019809999736 2153.2525310000055 2301.425217000011 2345.7890729999635 2487.819837999996
App start regularAppStart	Baseline Mean: 0.025 ms Stdev: 0.005 ms (19.3%) Runs: 0.020548000000417233 0.021524999989196658 0.022136000043246895 0.023803999996744096 0.023803999996744096 0.024209999945014715 0.026285999978426844 0.03682500007562339 Current Mean: 0.025 ms Stdev: 0.004 ms (16.9%) Runs: 0.02172800002153963 0.022054000000935048 0.02229799999622628 0.023111999966204166 0.023763000033795834 0.024169999989680946 0.026082000054884702 0.03535999997984618
App start time (CPU)	Baseline Mean: 154.588 % Stdev: 3.032 % (2.0%) Runs: 150.17349546001842 151.75041261148448 153.19055133810605 157.0538571261075 157.18023931776335 158.1773071731539 Current Mean: 156.901 % Stdev: 4.600 % (2.9%) Runs: 148.5396991273787 152.86475272323335 154.59480973324114 155.10880662339412 159.736714517591 160.4016648363146 160.82644393938259 163.13438238127955
App start time (FPS)	Baseline Mean: 57.844 FPS Stdev: 1.703 FPS (2.9%) Runs: 55.107489304472004 56.0982928508171 57.39432223546879 57.52587874695508 59.224918773637285 59.58690738429183 59.96670772248177 Current Mean: 59.784 FPS Stdev: 0.452 FPS (0.8%) Runs: 58.77512689419158 59.92911343561765 60 60 60 60
App start time (RAM)	Baseline Mean: 352.439 MB Stdev: 8.207 MB (2.3%) Runs: 340.0572916666667 340.7174479166667 349.75390625 351.2109375 353.88125 360.4697265625 361.0322265625 362.3916015625 Current Mean: 356.692 MB Stdev: 3.676 MB (1.0%) Runs: 351.7682291666667 353.6223958333333 354.5 354.6904296875 355.236328125 360.6940104166667 360.8059895833333 362.220703125

Fixed Issues

$ N/A
PROPOSAL: #43482 (comment)

Tests

run e2e pipeline and be sure it's green;

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-06-18T08:48:11Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cristipaval · 2024-06-24T10:56:49Z

Adding @mountiny and @hayata-suenaga who reviewed the original PR

mountiny · 2024-06-24T12:43:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

kirillzyusko · 2024-06-24T14:31:13Z

Let's merge #43482 first and then I'll resolve conflicts and revise this PR 👀

mountiny · 2024-06-27T22:07:10Z

@kirillzyusko is this ready to be merged?

hayata-suenaga · 2024-06-28T02:49:42Z

#43482 was merged, so this one is ready to be merged 😄

hayata-suenaga

looks good to me 😄

OSBotify · 2024-06-28T02:58:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:00:39Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:13:06Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:56:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:19:05Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kirillzyusko requested a review from a team as a code owner June 18, 2024 08:46

melvin-bot bot requested review from cristipaval and removed request for a team June 18, 2024 08:48

cristipaval requested review from mountiny and hayata-suenaga and removed request for cristipaval June 24, 2024 10:56

mountiny assigned kirillzyusko Jun 24, 2024

kirillzyusko added 3 commits June 27, 2024 12:19

feat: initial implementation

b7d5912

fix: implement last changes

93d5e4a

fix: changes after rebase

c97e8b5

kirillzyusko force-pushed the e2e/different-units-per-test branch from bc792e3 to c97e8b5 Compare June 27, 2024 09:22

hayata-suenaga approved these changes Jun 28, 2024

View reviewed changes

hayata-suenaga merged commit 1d607ac into Expensify:main Jun 28, 2024
15 checks passed

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] e2e: support for different units #43890

[NoQA] e2e: support for different units #43890

kirillzyusko commented Jun 18, 2024

melvin-bot bot commented Jun 18, 2024

cristipaval commented Jun 24, 2024

mountiny commented Jun 24, 2024 •

edited

Loading

kirillzyusko commented Jun 24, 2024

mountiny commented Jun 27, 2024

hayata-suenaga commented Jun 28, 2024

hayata-suenaga left a comment

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

[NoQA] e2e: support for different units #43890

[NoQA] e2e: support for different units #43890

Conversation

kirillzyusko commented Jun 18, 2024

Details

Performance Comparison Report 📊

Significant Changes To Duration

Meaningless Changes To Duration

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 18, 2024

cristipaval commented Jun 24, 2024

mountiny commented Jun 24, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

kirillzyusko commented Jun 24, 2024

mountiny commented Jun 27, 2024

hayata-suenaga commented Jun 28, 2024

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

mountiny commented Jun 24, 2024 •

edited

Loading