Fix bug with Removed member can be clicked #40758

ZhenjaHorbach · 2024-04-23T08:30:33Z

Details

Group chat - Removed member can be clicked on when removed offline

Fixed Issues

$ #40442
PROPOSAL: #40442 (comment)

Tests

Open App
Go to FAB > Start chat
Create a group chat
Click on the header > Members
Go offline
Remove a member
Verify that removed member is not clickable
Go back and create a group room
Click on the header > Members
Go offline
Remove a member
Verify that removed member is not clickable

Verify that no errors appear in the JS console

Offline tests

Open App
Go to FAB > Start chat
Create a group chat
Click on the header > Members
Go offline
Remove a member
Verify that removed member is not clickable
Go back and create a group room
Click on the header > Members
Go offline
Remove a member
Verify that removed member is not clickable

QA Steps

Open App
Go to FAB > Start chat
Create a group chat
Click on the header > Members
Go offline
Remove a member
Verify that removed member is not clickable
Go back and create a group room
Click on the header > Members
Go offline
Remove a member
Verify that removed member is not clickable

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_ziyxlrrc.mp4

Android: mWeb Chrome

android_ziyxlrrc.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web_OrtUHUIC.mp4

MacOS: Desktop

desktop_TeFHvxPe.mp4

melvin-bot · 2024-04-23T08:30:38Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-04-23T08:33:11Z

@jjcoffee
Hello )
PR is ready

jjcoffee · 2024-04-23T12:46:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-04-23_15.51.57.mp4

Android: mWeb Chrome

android-chrome-2024-04-23_15.54.43.mp4

iOS: Native

ios-app-2024-04-23_15.42.11.mp4

iOS: mWeb Safari

ios-safari-2024-04-23_15.44.29.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-04-23_15.46.03.mp4

MacOS: Desktop

desktop-app-2024-04-23_15.48.01.mp4

jjcoffee

LGTM! Thanks for fixing on rooms too! 🚀

marcaaron

LGTM thanks!

OSBotify · 2024-04-23T19:21:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-24T00:08:50Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T13:47:09Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2024-09-23T06:07:12Z

src/pages/RoomMembersPage.tsx

@@ -204,7 +204,7 @@ function RoomMembersPage({report, session, policies}: RoomMembersPageProps) {
                keyForList: String(accountID),
                accountID,
                isSelected: selectedMembers.includes(accountID),
-                isDisabled: accountID === session?.accountID,
+                isDisabled: accountID === session?.accountID || pendingChatMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,


It doesn't make sense to remove or make admin of optimistically invited member

[$250] Group chat-Member invited, made admin & removed in offline is showed on returning online. #47686

[Payment due 2024-09-24][$250] Android - Room - For new user, invited member is shown with email but removed user shown as hidden #48577

To fix these, we added || details?.isOptimisticPersonalDetail condition to both places.

Fix bug with Removed member can be clicked

3c8d2c5

ZhenjaHorbach requested a review from a team as a code owner April 23, 2024 08:30

melvin-bot bot requested review from jjcoffee and removed request for a team April 23, 2024 08:30

jjcoffee approved these changes Apr 23, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron April 23, 2024 14:13

marcaaron approved these changes Apr 23, 2024

View reviewed changes

marcaaron merged commit ffd468b into Expensify:main Apr 23, 2024
16 of 66 checks passed

github-actions bot mentioned this pull request Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

lanitochka17 mentioned this pull request Apr 24, 2024

[$250] Members - Deleted members in offline mode return after re-logging #40898

Closed

6 tasks

melvin-bot bot mentioned this pull request Apr 25, 2024

[HOLD for payment 2024-05-02] [$250] Group chat - Removed member can be clicked on when removed offline #40442

Closed

6 tasks

aimane-chnaif reviewed Sep 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug with Removed member can be clicked #40758

Fix bug with Removed member can be clicked #40758

ZhenjaHorbach commented Apr 23, 2024 •

edited

Loading

melvin-bot bot commented Apr 23, 2024

ZhenjaHorbach commented Apr 23, 2024

jjcoffee commented Apr 23, 2024 •

edited

Loading

jjcoffee left a comment

marcaaron left a comment

OSBotify commented Apr 23, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

aimane-chnaif Sep 23, 2024

Fix bug with Removed member can be clicked #40758

Fix bug with Removed member can be clicked #40758

Conversation

ZhenjaHorbach commented Apr 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 23, 2024

ZhenjaHorbach commented Apr 23, 2024

jjcoffee commented Apr 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee left a comment

Choose a reason for hiding this comment

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 23, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

aimane-chnaif Sep 23, 2024

Choose a reason for hiding this comment

ZhenjaHorbach commented Apr 23, 2024 •

edited

Loading

jjcoffee commented Apr 23, 2024 •

edited

Loading