-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [Search v2.4] [App] Introduce <SearchRouter> component #49118
Comments
Triggered auto assignment to @jliexpensify ( |
hey, since i was preparing a draft POC while writing the doc, I have some code for this, please assign me. |
Job added to Upwork: https://www.upwork.com/jobs/~021834650090913251873 |
Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to @twisterdotcom ( |
@Kicu, @twisterdotcom, @luacmartins, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
PR is going through deployment: #48785 |
@Kicu, @twisterdotcom, @luacmartins, @ikevin127 Eep! 4 days overdue now. Issues have feelings too... |
also I might need to add a few more followups after my PR was merged, because we were trying to merge it ASAP so more tasks gets unblocked. |
Sounds good. Let's work on the follow ups |
@Kicu I think this issue is done, right? I believe we addressed all the follow up we needed to? Am I missing something? |
@luacmartins yes I believe so. (because the input component to type in query is shared between the Router and SearchResults page). This one we can consider done. |
Cool, I think only thing left is payment then, once this PR gets deployed to prod |
@luacmartins If payment will happen here, #49122 can be closed as it was addressed in the same PR. Also, I reviewed 2 PRs which tagged this issue in the Fixed Issues section:
|
Implement this section of the doc
cc @Kicu @289Adam289 @Guccio163 @SzymczakJ
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @KicuThe text was updated successfully, but these errors were encountered: