[Hold for payment][$500] Chat - Video leads to not here page after reopening chat

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to chat
3. Upload a video
4. Play the video and verify that it plays
5. Go to LHN
6. Reopen the chat in Step 2
7. Play the video

Expected Result:

The video is played without issue

Actual Result:

The video leads to not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385618_1708429871937.Screen_Recording_20240220_195026_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018ba9a1f89a9fa057
• Upwork Job ID: 1759956026491719680
• Last Price Increase: 2024-02-20
• Automatic offers:
• alitoshmatov | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018ba9a1f89a9fa057

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After reopening the chat page that has a video, pressing the video (on small screen) or expanding it will show not found page.

What is the root cause of that problem?

When the not found page shown, the reportID params in the URL is empty. We get the reportID from the active route.

App/src/components/HTMLEngineProvider/HTMLRenderers/VideoRenderer.tsx

Lines 25 to 29 in 669ac33

	const activeRoute = Navigation.getActiveRoute();
	const {reportID} = parseReportRouteParams(activeRoute);
	return (
	<VideoPlayerPreview

But the reportID could be empty when the page is still transitioning. If the reportID is empty, we will see the not found page.

App/src/components/HTMLEngineProvider/HTMLRenderers/VideoRenderer.tsx

Lines 36 to 39 in 669ac33

	onShowModalPress={() => {
	const route = ROUTES.REPORT_ATTACHMENTS.getRoute(reportID, sourceURL);
	Navigation.navigate(route);
	}}

What changes do you think we should make in order to solve the problem?

Get the reportID every time we press the video.

onShowModalPress={() => {
    const activeRoute = Navigation.getActiveRoute();
    const {reportID} = parseReportRouteParams(activeRoute);

    const route = ROUTES.REPORT_ATTACHMENTS.getRoute(reportID, sourceURL);
    Navigation.navigate(route);
}}

What alternative solutions did you explore? (Optional)

We can get the reportID from ShowContextMenuContext just like we did in ImageRenderer.

App/src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx

Lines 79 to 86 in 669ac33

	<ShowContextMenuContext.Consumer>
	{({anchor, report, action, checkIfContextMenuActive}) => (
	<PressableWithoutFocus
	style={[styles.noOutline]}
	onPress={() => {
	const route = ROUTES.REPORT_ATTACHMENTS.getRoute(report?.reportID ?? '', source);
	Navigation.navigate(route);
	}}

[stitesExpensify]

This is coming from #30829

@francoisl do you think we should accept the above proposal? Or would you rather wait until next week after the deploy freeze to handle this?

[francoisl]

Yep, we should still try to address deploy blockers during the freeze. If the fix works, let's go with it.

[stitesExpensify]

Great. @alitoshmatov what do you think of the above proposal?

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[alitoshmatov]

@bernhardoj 's proposal does solve this issue and provide correct RCA

We can go with this proposal

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @alitoshmatov

[melvin-bot]

This issue has not been updated in over 15 days. @stitesExpensify, @bernhardoj, @alitoshmatov eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[alitoshmatov]

Looks like Melvin failed here and we missed this issue. The PR went to into production 3 weeks ago. Can we proceed with next step

@stitesExpensify

[stitesExpensify]

Does the issue still exist on production? If so then yes let's proceed!

[alitoshmatov]

@stitesExpensify This issue does not exist in production. The payment is not handled yet

[stitesExpensify]

Oh, my apologies I misunderstood your question. I will get a bug zero member assigned!

[melvin-bot]

Current assignee @alitoshmatov is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[stitesExpensify]

Hi @sonialiap Melvin didn't trigger here, but the issue is already completed. Could you please process the payment for @bernhardoj and @alitoshmatov ?

[sonialiap]

Thanks for the note about payment, processing now

Payment summary:

• @bernhardoj fix $500 - offer sent
• @alitoshmatov reviewer $500 - offer sent

[alitoshmatov]

@sonialiap Accepted the offer

[sonialiap]

Both payments made ✔️