Deploy Checklist: New Expensify 2024-02-19

[github-actions]

Release Version: 1.4.43-20
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Video player #30829
• Go back to correct page in referral page #32329
• [TS migration] Migrate 'DistanceEReceipt.js' component to TypeScript #33804
• [WAVE 7] Hold Requests: Individual Money Request Page, Reason Interstitial, Banner #33897
• Add violation message to MoneyRequestPreview #33969
• [TS migration] Migrate 'ValuePicker' component to TypeScript #34654
• Fix: Pin & Delete request appear on Receipt image when quickly tap on receipt and 3-Dot menu #34720
• [TS migration] Migrate RoomMembersPage to typescript #34957
• Allow for multiple levels of tags on workspace #34983
• fix: include created parameter in split bill API calls #35141
• Fix: Focus mode - User priority mode is switched back to focus automatically #35362
• Fix for extra padding in options list #35541
• fix: cretae seperated logo for icons #35544
• [No QA][TS migration] Migrate 'react-native-airship.js' mock to TypeScript #35676
• Create Card-Revenue-Share.md #35700
• Updated total amount when change the different currency #35880
• fix: Assigned cards tile uses cardholderName- lastFourDigits instead of bankName - lastFourDigits #35885
• [No QA][TS migration] Migrate react-native-permissions mock #35886
• [TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript #25175 #35890
• [No QA][TS migration] Migrate config.local from e2e to Typescript #35902
• Fix: Cannot deselect disabled category #35922
• Reintroduce animated input for Markdown composer #35973
• Fix bank account shows not found when trying to pay with business bank account #35981
• [No QA] [TS migration] Migrate 'versionUpdaterTest.js' test to TypeScript #36006
• [No QA] [TS migration] Migrate 'isReportMessageAttachmentTest.js' test to TypeScript #36024
• [New architecture] Upgrade @rnmapbox/maps #36147
• [New architecture] Upgrade react-native-camera-roll #36154
• Create create-a-workspace-for-yourself.md #36163
• [NO QA] Docs/how to build app on physcial device #36179
• Change the global create and DM create tooltips to read Create #36242
• Adds 'Required' label for merchant on workspaces & updates P2P requirements for worskpaces #36252
• Consistent system paid message #36298
• Conversation scrolling to the beginning of the chat. #36309
• Fix report screen header skeleton spacing #36317
• Fix cursor moves to the left after pasting a number to the money request input #36318
• [No QA] [TS migration] Migrate 'FileUtilsTest.js' test to TypeScript #36340
• Create Add-profile-photo.md #36346
• [No QA] [TS migration] Migrate 'launchApp.js' test to TypeScript #36393
• Group chat stacked avatars are different in Search list and LHN #36403
• [No QA][TS migration] Migrate 'GitUtilsTest.js' test and 'GitUtils.js' .github file to TypeScript #36406
• General implementation profile page #36426
• Making avatar url be only accountID based #36431
• Reattempt: Fix doing text selection on money request amount input swipes the tab #36463
• Fix Workspace - Infinite skeleton loading when member is removed from… #36477
• Prevent calling Welcome.show() on the workspace settings screen #36498
• Update report description max length to 500 #36514
• [No QA] Fix import of setUpTests from Reanimated #36526
• Fix a predicted report status for a next step #36529
• Fix: Delay when change default skin color #36530
• Move violation message below billable field #36533
• Simplify native attachment gallery paging context and improve code #36534
• [No QA] cleanup after pod install from multiple PRs #36537
• Ensure isOptimisticReport is set and fix issues with optimistic reports getting deleted on reconnect #36538
• fix: Add parentReportAction to memo dependencies #36546
• [NoQA] dev: fail e2e tests after three errors #36561
• [NO QA] Fix workflow merging issue for performance tests #36562
• [NoQA] [Audit][Implementation] getOrderedReportIDs - iouReportAmount removal #36566
• [NoQA] dev: fix e2e test comparison worked in the wrong direction #36572
• fix: Set cursor to default when the steps are non-clickable #36573
• [Update Account Settings] Fix Wallet Page style #36583
• Fix - A tooltip does not appear above the mentioned user with no conversation history #36584
• [FIX]: "PO boxes and mail drop addresses are not allowed" appears twice in Address  #36585
• Fixed state reset on going back from amount step #36586
• [FIX]: "Company type" appears twice in the selection list #36589
• [Audit][Implementation] Intl collator replacement #36592
• Delete docs/articles/expensify-classic/getting-started/support/Expens… #36593
• Update redirects.csv #36594
• [NoQA] post slack update about failed e2e pipeline to new slack room #36612
• [No QA] Remove unused isSidebarLoadedReady dead code #36615
• Fix: Bank account - Next button is not disabled when Plaid modal is loading #36621
• Update redirects.csv #36630
• Fix - display the home route when the app restarts on mobile platforms #36637
• [NO QA] fix: collecting logs on dev #36659
• Fix reaction tooltip is still shown when the reaction list popover is open #36660
• Emoji picker: Round down window width (estimated list size) #36674
• ci: reuse uploaded baseline app for e2e perf. regression testing pipeline #36686
• Fix infinite loading in header when thread's parent message is deleted #36688
• [ImgBot] Optimize images #36691
• Create Merge-accounts.md #36701
• fix: Distance request preview in the main chat is grayed out offline when created online #36702
• Add UPDATEROOMDESCRIPTION report action type #36726
• Hide the double offline indicator in bank steps #36763
• [No QA] Rename patch for react-native-camera-roll #36775
• [Snyk] Upgrade electron-updater from 6.1.7 to 6.1.8 #36780
• [NoQA] dev: run e2e test in AWS with ts-node #36788
• [NoQA] Remove Lounge code  #36797
• [CP STAGING] fix crash when saving a reason during hold request flow #36841
• [CP STAGING] Fix: App crashes when open default workspace avatar #36842
• Add more space for avatar picker in workspace profile page #36844
• [CP Staging] fix crash on money request confirmation page #36858
• [CP Staging] fix: On full screen mode, when the video ends, the play button does nothing #36914
• [CP Staging] Fix: Expense - App crashes when changing date, description, merchant of the request #36919
• [CP Staging] Show a search bar when there is a lot of tags #36929
• Revert "Consistent system paid message" #36932
• Revert "Conversation scrolling to the beginning of the chat." #36936
• Fix: Context menu not appear on long press video #36940
• Implement same tag splitting logic we have in the API #36978
• [No QA] Allow raw HTML on web with a flag #36981
• [CP Staging] Fix/36991: Click on workspace description do nothing #37001
• Update correctly amount when updating waypoint #37005
• [CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview #37007
• Fix app returns to previous thread when scrubbing video in thread #37036
• Fix opening video preview leads to not found page #37066
• [CP Staging] Revert "Fix app returns to previous thread when scrubbing video in thread" #37161
• fix: Video - Invalid file is downloaded when downloading video. #37163
• Revert "[New architecture] Upgrade react-native-camera-roll" #37222

Deploy Blockers:

• [$500] [Held requests] - Pressing 'Enter' key doesn't serve as clicking on 'Got it' button #36825
• [Awaiting payment 7th March] [$500] Hold Request - 'Reason' is not translated to Spanish #36826
• [$500] Changing playback speed is not taking effect when changing playback speed before playing #36827
• [$500] Video file is unusable when editing name #36828
• [$500] Hold Request - Composer is focused while RHP is open #36829
• [$500] [Held requests] Red dot and hold request message do not show up on LHN until after refresh #36830
• [$500] Hold request - App crashes when saving a reason during hold request flow #36831
• [Regression - HOLD on #39078 [HOLD for payment 2024-04-03] HIGH: [Video] [$500] iOS Safari - Video file preview not displayed after selecting video from device gallery #36832
• [PAID] [$500] Video - Two different crashes occur when downloading video #36833
• [PAY 5th MARCH][$500] Tapping on Workspace avatar, app crashes #36834
• [$500] WS avatar does not have any indent from the bottom edge of the header #36835
• [$500] Hold Request - "Hold/unhold request" text is not translated to Spanish #36836
• [HOLD #36894] [$500] [Held requests] "Reason" text is copied twice when using "Copy to clipboard" #36837
• [$500] Distance - App crashes when creating request and opening Ereceipt offline #36853
• [$500] Distance - App crashes when creating a distance request after creating a new workspace #36854
• [HOLD for payment 2024-03-15] [$500] Expense - App crashes when changing date, description, merchant of the request #36857
• [$500] Tag - No search field when there are more than 9 tags in the tag list #36859
• [$500] [MEDIUM] Tags: Unable to unselect or select a different tag after the request is created #36860
• [$500] Chat - For video uploaded, download option is not shown. #36861
• [HOLD for payment 2024-03-04] [$500] Video - On full screen mode, when the video ends, the play button does nothing #36865
• [$500] iOS - Chat - Action menu does not appear when tap and hold on a video #36868
• [$500] Assigned cards have the bank name only without last 4 digits of card number #36869
• [HOLD for payment 2024-03-14] [$500] iOS - Photos - Error message displayed even though the image has been downloaded #36870
• [HOLD for payment 2024-04-09] [HOLD for payment 2024-03-13] [$500] Video - Play&Pause buttons don't function in preview mode if expanded the video before #36873
• [$500] Fab - Hidden not displayed on chat header & LHN when creating an IOU #36885
• [$500] Settings - Delay Occurs When Navigating Back from Accounting Settings #36888
• [$500] Tag - No violation message for missing tag when tag is not selected #36889
• [HOLD for payment 2024-04-03][$250] Chat - Missing Tooltip for Video Expand Button #36890
• [$500] Distance - Total amount in report is not reset to 0.00 when changing distance request offline #36892
• [$500] [Held requests] System message for hold/unhold request is not gray like other system messages #36894
• [Hold for payment][$500] Chat - Video leads to not here page after reopening chat #36899
• [$500] Home - Workspace page appears on the right instead of chat view after returning from settings #36900
• [HOLD for payment 2024-03-08] [$500] Chat - Download option in three-dot menu is still available in offline mode #36901
• [$500] Chat - Pressing ESC closes the video preview modal instead of Download and Playback modal #36902
• [HOLD for payment 2024-04-05] Chat - Video does not resume playing after regaining internet connection #36903
• Attachment-App crashes when scrubbing through an mp4 file on attachment upload preview #36905
• [HOLD for payment 2024-03-13] [$500] Video - App returns to previous thread when scrubbing video in thread #36906
• [$500] Web - Chat - Blank space below LHN & composer when entering full screen mode in thread conversation #36910
• [$500] Expense - Old amount is copied to clipboard when the request amount is changed #36911
• [$500] IOU - The selected category moves to the top of the list when <8 categories active #36912
• [$500] [MEDIUM] Tags: Selected parent tag with sub-tag is displayed incorrectly #36916
• [$500] IOU - Description is not copied when copying IOU preview to clipboard #36917
• [$500] IOU - Total paid amount instead of individual amount is copied from each paid IOU preview #36924
• [HOLD for payment 2024-04-03] [LOW] [Splits] [$500] Chat - Error "a previously existing chat between these users." is missing when go online #36928
• [$500] [MEDIUM] Scan Receipt - After edit a request while scanning, red dot disappears, scanning resumes #36930
• [BZ checklist] [$500] [Held requests] IOS - Hold Request - Keyboard is up but the field is not focused with error message showing #36948
• [$500] IOU - There is no violation in the IOU details #36951
• [HOLD for payment 2024-03-07] [$500] Video - Unable to adjust volume by clicking on any part of the volume slider #36952
• [$500] Web - Video - Console error shows up when dismissing video preview after viewing full screen #36955
• [$500] Chat is showing bold in the LHN for the sender #36959
• [$500] Public room - Unable to play video after navigating to LHN and back to public room #36975
• [Payment due][$500] Clicking on workspace description does nothing #36991
• [HOLD for payment 2024-06-28] [Held requests] Hold Request education modal reappears after relogin #37012
• [HOLD for payment 2024-03-19] [$500] [Held Requests] Hold request modal does not dismiss for Employee after admin pays the request #37014
• [$250] [Held requests] Markdown isn't applied to the "Hold" message #37015
• [$500] Hold Request - Submitting report with expenses that on hold returns unexpected error #37017
• [$500] Hold Request - Approving report that has expenses on hold removes "hold" status #37020
• Video - Invalid file is downloaded when downloading video #37092
• [HOLD #37199][$500] Remove members out of a workspace are not crossed out in offline mode #37109
• [PAID] [$500] Chat - When opening the mp4 video that was just sent, console error appears #37142
• [$500] Chat - The video is reloaded every time you open it #37168

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.43-0 🚀

[Julesssss]

Checking off #36853 as it's no longer occuring

[cristipaval]

Checking off #36854 as the fix is already CP'd into staging

[Julesssss]

Checking off #36902 as it's an edge case

[tgolen]

Checking off #36912 as NAB

[kavimuru]

Regression is 1% left.
#36637 is failing in mweb with #36926 and repro in PROD. Checking it off.
#36154 failing with #36870 in iOS
#36147 failing with #36854
#35922 failing with #36860
#35885 failing with #36869
#32329 failing with #36864 repro in PROD, checking it off

We are still working on the PRs.

[francoisl]

Demoting 36903, checking it off
Demoting 36861, needs backend changes and NAB

[Julesssss]

Checking off #36959 as its occurring on prod

[kavimuru]

Regression is completed. We are waiting for the build version to validate CPs
unchecked PRs:
#36154 failing with #36870 in iOS
#36147 failing with #36854
#35922 failing with #36860
#35885 failing with #36869
#36426 failing with #36913 repro in PROD, checking it off
#36538 failing with #36928
#33969 failing with #37013 repro in PROD checking it off
#35886 looks like internal testing.

Open Blockers:
#36834
#36835
#36857
#36859
#36860
#36865
#36868
#36870
#36885
#36888
#36889
#36905
#36906
#36911
#36916
#36917
#36924
#36951
#36952
#36955
#36991
#37012
#37014
#37015
#37020
#37017

[rlinoz]

Demoting #37012

[chiragsalian]

@kavimuru

• [$500] Distance - App crashes when creating a distance request after creating a new workspace #36854 is on staging. Can you retest [New architecture] Upgrade @rnmapbox/maps #36147.
• [CP STAGING] Fix: App crashes when open default workspace avatar #36842 is on staging. Can you test and then clear deployblocker label from [PAY 5th MARCH][$500] Tapping on Workspace avatar, app crashes #36834 if it passes.
• Add more space for avatar picker in workspace profile page #36844 is on staging and ready for qa team to test.
• [CP Staging] Show a search bar when there is a lot of tags #36929 is on staging and ready for qa team to test.
• Revert "Consistent system paid message" #36932 is on staging and ready for qa team to test. If it passes please remove deploy blocker label from its linked PR
• Revert "Conversation scrolling to the beginning of the chat." #36936 is on staging and ready for qa team to test. If it passes please remove deploy blocker label from its linked PRs 1 and 2
• [PAY 5th MARCH][$500] Tapping on Workspace avatar, app crashes #36834 - Addressed by [CP STAGING] Fix: App crashes when open default workspace avatar #36842 which is on staging and ready for qa team to test.
• [HOLD for payment 2024-03-15] [$500] Expense - App crashes when changing date, description, merchant of the request #36857 - Addressed by [CP Staging] Fix: Expense - App crashes when changing date, description, merchant of the request #36919 which is on staging and ready for qa team to test.
• [$500] Tag - No search field when there are more than 9 tags in the tag list #36859 - Addressed by [CP Staging] Show a search bar when there is a lot of tags #36929 which is on staging and ready for qa team to test.
• [$500] Settings - Delay Occurs When Navigating Back from Accounting Settings #36888 - Addressed by Revert "Conversation scrolling to the beginning of the chat." #36936 which in on staging and ready for qa team to test.
• [$500] Home - Workspace page appears on the right instead of chat view after returning from settings #36900 - Addressed by Revert "Conversation scrolling to the beginning of the chat." #36936 which in on staging and ready for qa team to test.
• [$500] Expense - Old amount is copied to clipboard when the request amount is changed #36911 - I'm checking it off since the issue is closed.
• [$500] [MEDIUM] Tags: Selected parent tag with sub-tag is displayed incorrectly #36916 - Looks like the related PRs are on staging. Can qa team test if issue still persists and if not clear out the blocker label.
• [$500] IOU - Total paid amount instead of individual amount is copied from each paid IOU preview #36924 - comment was left for QA to retest.

I'll post on slack shortly to move blockers that are waiting on us to address.

[shubham1206agra]

@chiragsalian Please CP #37001.

[techievivek]

@shubham1206agra I have requested internally for the CP.

[techievivek]

#37001 is CPed to staging and is no longer a blocker.

[kavimuru]

@chiragsalian
#36147 is a pass and checked it off
#36842 is fixed and removed blocker label from #36834
#36844 is checked off
#36929 is checked off
#36917 is fixed and removed blocker label
#36900 and #36888 are fixed and removed blocker label
#36842 is a pass and checked off
#36919 is a pass and checked off
#36929 is a pass and checked off
#36916 is still failing in all the platforms
#36924 is fixed

[rlinoz]

PR #36914 was CP'd and fixed #36865, tested and checking both off.

[chiragsalian]

Checking off #35922 as per comment
Checking off #36932 and #36936 because their linked PRs are checked off.
#36914 is on staging and ready for qa team to test
#36860 - we believe this has been addressed by #36919. Can you retest?
#36868 - has a PR on staging and ready for qa team to test.
#36892 - can qa team retest or check it off the list. It looks like its linked PR was CP'd and tested on staging.
Checking off #36924 since its mentioned as fixed in previous comment
Checking off #36951 since issue is no longer reproducible

[kavimuru]

@chiragsalian
#36914 is a pass checked off
#36860 , #36868 and #36892 are all fixed.

[luacmartins]

Checking off #37109. It was a known issues during dev on a WIP feature. We have a PR up to fix it.

[chiragsalian]

Checking off #35885, - reasoning
Checking off #36857 - reasoning
I've checked off #36860 , #36868 and #36892 since its mentioned as fixed in previous comment.
Checking off #36885 as per comment.
Checking off #36905 because its linked PR was CP-d and checked off.
Checking off #36991 because its linked PR was CP-d and checked off.

[chiragsalian]

CP-d #36978, can qa team test and if it passes verify if #36916 can be checked off.
Cp-d #37066, can qa team test and if it passes verify if #36899 can be checked off.

[francoisl]

37066/36899 tested on staging, checking both off

[kavimuru]

Unchecked PRs:
cp #37036 is still failing with #36906. See comment.
#36154 failing with #36870 in iOS

Open blockers:
#36870
#36906
#36916
#36952
#37092
#37168

[puneetlath]

Checking off #37036 as they'll continue to work on it in #36906 which is no longer a deploy blocker.

[puneetlath]

Checking off #36916 as it was fixed by #36978

[puneetlath]

Checking off #37168 as it's more of a feature/polish request than a bug/blocker.

[puneetlath]

Checking off #36952 as not a blocker as discussed here.

[puneetlath]