[$500] Tag - No search field when there are more than 9 tags in the tag list

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating PR : #35541

Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has more than 9 tags.

1. Navigate to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Request money > Manual.
4. Enter amount > Next.
5. Click Show more.
6. Click Tag.

Expected Result:

There will be a search field above tag list because there are more than 9 tags.

Actual Result:

There is no search field above tag list when there are more than 9 tags.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6385312_1708402897997.bandicam_2024-02-20_08-50-11-856.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014ce6942105099a0b
• Upwork Job ID: 1759888738434629632
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014ce6942105099a0b

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no search field above tag list when there are more than 9 tags.

What is the root cause of that problem?

Here's the commit that cause the bug: cf53298

In

App/src/components/TagPicker/index.js

Line 23 in 0f372c2

const policyTagsCount = PolicyUtils.getCountOfEnabledTagsOfList(policyTagList);

we're using policyTagList, and it's not correct, it should be policyTagList.tags

What changes do you think we should make in order to solve the problem?

change to policyTagList.tags

What alternative solutions did you explore? (Optional)

NA

[shubham1206agra]

Related to #34983
cc @rezkiy37

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue, because I am an author of a broken PR. It is still a regression period.

[shubham1206agra]

@rezkiy37 You can directly raise a PR here. No need for assignment.

[shubham1206agra]

Tagging @allroundexperts as the original issue C+ here.

[allroundexperts]

Thanks @shubham1206agra. Will review once the PR is up.

[rezkiy37]

Also, I have to mention that our threshold is 8 items to show a search bar and sections. So, users need 8 tags at least, not 9.

[rezkiy37]

A draft PR has been opened. Going to open for a public review soon.

[Beamanator]

@rezkiy37 is your PR ready for review yet? 🙏

Also @allroundexperts I'll assign you here & in the PR since you were the C+ for #34983

[Beamanator]

PR merged! I'll start a convo in slack to see if we want to CP this or if we're planning to :donothing: due to the deploy freeze

[tienifr]

@Beamanator Should we have a payment here since we used my proposal to fix this blocker?

Similar case: https://expensify.slack.com/archives/C01GTK53T8Q/p1707782382926619?thread_ts=1707781846.347169&cid=C01GTK53T8Q

[Beamanator]

@tienifr honestly good question, the fix is insanely small and, while you did also propose the correct fix, I think it's only worth a payout if @rezkiy37 used your proposed solution to guide his fix

[Beamanator]

Removing deploy blocker label since fix is now in staging

[rezkiy37]

...I think it's only worth a payout if @rezkiy37 used your proposed solution to guide his fix

Yeah, the proposal helped me to fix the bug.

[Beamanator]

Noice, then ya i think it does make sense for @tienifr to get some bonus for the help - cc @kevinksullivan , the payment pro in this issue

[kevinksullivan]

Just to clarify, @tienifr should be getting paid the same as others for the help, or a fractional "bonus"?

[tienifr]

@Beamanator Can you check the question above ^? Thanks

[kevinksullivan]

Payout summary:

• @allroundexperts $500
• @tienifr $125 (bonus for assisting with proposal)

@tienifr offer sent, let me know when you accept.

[tienifr]

@kevinksullivan I accepted, thanks!

[JmillsExpensify]

$500 approved for @allroundexperts based on summary.

[tienifr]

@tienifr $125 (bonus for assisting with proposal)

@kevinksullivan Could you help with payment here? Thanks!

[melvin-bot]

This issue has not been updated in over 15 days. @Beamanator, @kevinksullivan, @allroundexperts, @rezkiy37 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[kevinksullivan]

all set