Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Bank account - Beneficial owner step is restarted after coming back online #36459

Closed
2 of 6 tasks
m-natarajan opened this issue Feb 14, 2024 · 7 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Feb 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Pre-requisite: the user must be logged in and have created a workspace.

  1. Go to Workspace > Bank account.
  2. Initiate the add BA flow until you reach the Beneficial owner step.
  3. Try to add an additional beneficial owner.
  4. In the middle of the process (on the SSN, page for example) disable the internet connection.
  5. Verify the bottom banner for offline status appears.
  6. Enable the internet connection.
  7. Wait until it loads.

Expected Result:

The same page when the user was offline should be displayed when coming back online.

Actual Result:

The beneficial owner step is restarted after coming back online.

note: Also, if the user enters the beneficial owner's data without saving it and goes back, when the page is reopened, the data entered previously is not saved.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378788_1707870302997.Dtxx1604_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0112558f96658aedef
  • Upwork Job ID: 1757590010053427200
  • Last Price Increase: 2024-02-14
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 14, 2024
@melvin-bot melvin-bot bot changed the title Bank account - Beneficial owner step is restarted after coming back online [$500] Bank account - Beneficial owner step is restarted after coming back online Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0112558f96658aedef

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 14, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 14, 2024

Auto-assign attempt failed, all eligible assignees are OOO.

@Beamanator
Copy link
Contributor

@Beamanator Beamanator self-assigned this Feb 14, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 14, 2024
@mountiny
Copy link
Contributor

@anmurali posted here https://expensify.slack.com/archives/C07J32337/p1707880864491329 I agree this is not bug, we save the details in backend once the step is saved so in this case it makes sense its missing after going back

I think we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants