Deploy Checklist: New Expensify 2024-02-13

[github-actions]

Release Version: 1.4.41-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Switch NavLink to Link (mobile can't use NavLink) #21
• Migrate index.native.js to function component #24615
• feat: app sounds  #31055
• Fix chat infinite loading when opening a chat with report id of 0 #33394
• [TS migration] Migrate 'withReportAndPrivateNotesOrNotFound.js' HOC to TypeScript #34014
• Use error prop for violations for consistent styling #34303
• perf: smooth search transition #34422
• Fixed focus behavior and optimize active element role implementation #34480
• [Wave 6] Bank Account Flow Refactor #34498
• [TS Migration] Migrate NewChatPage #34638
• [TS migration] Migrate 'Wallet' page to TypeScript #34722
• [TS migration] Migrate 'WorkspaceTravel' page to TypeScript #34752
• Fix Workspace Rate Unit Form Flow #34849
• [TS migration] Migrate RoomInvitePage to typescript #34956
• [TS Migration] Migrate WorkspaceCard to Typescript #34963
• Feature: new security section, links #34987
• iOS - Login - The splash screen glitches and flashes on launch #35185
• Display require field above show more button #35287
• [TS migration] Migrate 'SignInDesktop' page #35406
• [No QA][TS migration] Migrate 'react-native-key-command.js' mock to TypeScript #35411
• [NoQA] Update Expensify-Playbook-For-Small-To-Medium-Sized-Businesses.md #35444
• [TS migration] Migrate 'FeatureList.js' component to TypeScript #25039 #35492
• Language - Error message on New contact method page remains on Spanish #35509
• fix: Android - It is impossible to scan the receipt with the camera, an error is displayed. #35640
• [TS migration] Removed async-storage.js mock #35645
• [Update Account Settings] Preferences, About, Security #35672
• Fix: add Noto Color Emoji to support flags on Windows #35790
• Check if the policy contains only errors #35801
• [Update Account Settings] Restyle Wallet Page #35806
• [No QA][TS migration] Migrate 'console.js' mock to TypeScript #35812
• [No QA][TS migration] Migrate react-native-config mock #35834
• 20354 task assignees list refactor #35841
• update workspace name #35846
• Fix/34608: Remove old CreatedPage  #35853
• fix: use the entire personal details list instead of participants' one #35873
• Do not render whispers targeted to others #35943
• Fix logic open in app #35978
• [New Architecture] Upgrade react-native-svg #36007
• fix: Show loader while fetching the report #36014
• [No QA] Ignore lottie warnings #36114
• [New architecture] Upgrade react-native-picker-select #36117
• [New architecture] Upgrade react-native-document-picker #36118
• [New architecture] Upgrade @react-native-clipboard/clipboard #36151
• [No QA] [TS migration] Migrate 'ErrorUtilsTest.js' test to TypeScript #36161
• Change report name in mast head upon modification #36165
• [No QA] [TS migration] Migrate 'generateMonthMatrixTest.js' test to TypeScript #36167
• Fix bug with Room - Workspaces listed in room are not listed in alphabetical order #36178
• Fix focus is in edit report action after ctrl+k when delete confirm modal appears #36195
• Fix description and merchant text style is different #36204
• Make workspace list header position sticky #36205
• fix: Workspace highlighted member blinks when check/uncheck mark. #36207
• fix: Add fallback icons for thumbnails #36214
• fix: update lastActorAccountID for transactionThread #36219
• Feature/35711 header invite remove button redesign #36220
• fix deleted workspace offline not visible & crossed out #36224
• fix workspace chats and rooms not archived when delete policy offline #36225
• Using lastMentionedTime to check if chat is unread #36276
• Fix hidden of member tooltip #36297
• fix: The back and forward keys are not working properly for navigating back to a characters #36303
• Bump expensify-common version #36310
• Fix heading font size in composer with Live Markdown Preview #36319
• Fix Markdown characters being too faint in Live Markdown Preview #36320
• [Snyk] Upgrade electron-serve from 1.2.0 to 1.3.0 #36356
• Remove limit on workspace name as per new standard allow only upto 100  #36369
• [NoQA] Fixed translation to trackDistanceChooseUnit #36402
• [noQA] task assignees list refactor typecheck fixes #36423
• [CP Staging] Add bottom margin to About Page and fix Status Bar color on Preferences Page #36452
• [CP Staging] Fix a crash when requesting money #36470
• [CP Staging] fix: followup fixes for vbba refactor #36472
• [CP Staging] Fix/Profile - Tapping share code link directs to hmm not here page #36507
• Update version of expensify-common #36525
• [No QA] Pin cloudflare cli to 2.17.0 #36539
• fix(Violations): fix behaviour of merchant errors #36550

Deploy Blockers:

• [HOLD #368997] [$500] Web - New Dot tab reloads every time user switches to another tab #36343
• [HOLD for payment 2024-02-26] [Payment Due 2-21-24] [$500] App crashes after selecting participant when requesting money #36433
• Task - Assignee list opens with some delay #36434
• Reimbursements - Focus (cursor) is not appearing in amount input field #36435
• [HOLD for payment 2024-02-26] Reimbursements - Error message is not left aligned to other items #36436
• [HOLD for payment 2024-02-26] Emoji appears in chat with slight delay after sending it #36437
• [HOLD for payment 2024-02-26] Reimbursements - Clicking on currency doesn't work #36438
• [HOLD for payment 2024-03-11] [HOLD for #36401] [$500] Reimburse - Pressing 'Enter' key on 'Rate' page refreshes the page #36439
• [HOLD for payment 2024-02-26] [$500] About - Footer text has no bottom margin #36444
• Onfido triggers after personal info step instead of after Business information steps #36447
• [HOLD for payment 2024-02-26] [$500] Routing number field is not auto focused. #36448
• [HOLD for payment 2024-02-26] [$500] On Onfido setup, the numbers at the top can be clicked #36449
• [$500][MEDIUM] Bank account - Fields are empty after navigating back to add BA modal #36450
• [$500] [MEDIUM] Second and third numbers are filled with green after completing personal info #36451
• [HOLD App#35519] [$500] [LOW] Android - App crashes after personal info page #36453
• [HOLD for payment 2024-02-26] [$500] Emojis not saved and not displayed in task description #36454
• [$500] Unable to mute all sounds on App #36455
• [$500] Bank account - Form is auto-submitted after disabling internet and killing app #36456
• [HOLD for payment 2024-02-26] Profile - Tapping share code link directs to hmm not here page #36457
• [HOLD for payment 2024-03-05] [$250] 2 bottom banners for offline status are displayed #36458
• [$500] Bank account - Beneficial owner step is restarted after coming back online #36459
• [$500] mWeb - Bank account - Page scrolls to the top when tapping on a field #36461
• Bank acount - Infinite loading & BA account page does not load after user is back online #36478
• [$500] Web - Bank Account - Infinite loading on bank info page on connecting bank accounts #36479
• IOU - Billable no longer valid violation is not displayed under the field #36481
• [HOLD for payment 2024-02-26] Chat - Emojis sent offline are not rendered in chat history #36483
• [$500] [MEDIUM] Bank account - Confirm button is not disabled when offline #36484
• Preferences - Mute all sounds from Expensify toggle does not update on secondary device #36487
• [$500] Workspace - LHN sorted by WS displays irrelevant Report #36490
• [$500] iOS - Notifications- User missing from chat Notification doesn’t mention the name or username #36494
• [$500] Bank account - Selected field is not auto-focused when redirected from the confirmation page #36499
• [HOLD for payment 2024-03-04] [$250] [MEDIUM] Bank account - "PO boxes and mail drop addresses are not allowed" appears twice in Address #36500
• Android - Bank account - Spinner does not appear instantly when reopening Connect with Plaid #36502
• [HOLD for payment 2024-03-05] [$250] [MEDIUM] Bank account - "Company type" appears twice in the selection list #36504
• [NEEDS CHECKLIST?] [$500] [MEDIUM] Bank account - Next button is not disabled when Plaid modal is loading #36505
• [HOLD for payment 2024-03-05] [$250] [MEDIUM] Bank account - Green box for completed part is clickable but nothing happens when clicking on it #36506
• Expense - "Next step" message changes when requesting money offline #36510
• [HOLD for payment 2024-02-26] IOU - Merchant error remains when Admin pay the request #36517

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[blimpich]

Demoting 36434

[amyevans]

Demoted #36437

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.41-0 🚀

[Beamanator]

Marked #36456 as NAB b/c we consider it a pretty strange edge case

[Beamanator]

Also marked #36455 as NAB, it's not really broken - and it's a test that we'll be updating over the next few weeks

[Beamanator]

#36458 also got marked nab as it's quite a small design bug that will be quick to fix

[kavimuru]

Regression is 4% left.
#31055 failing with #36455
#34752 failing with #36479
#34498 failing with #36449, #36451, #36447 and blocked in desktop with KI #36368
#34303 failing with #36433 on desktop
We still have validation pending on other unchecked PRs

[Julesssss]

Checking off #36502 as it's not a big problem. Will fix without it being a blocker

[dangrous]

#36487 is not a blocker and is sort of a dupe of #36455. Checking off.

[kavimuru]

Regression completed.

Unchecked PRs:
#31055 failing with #36455
#34752 failing with #36479
#34498 failing with #36449,#36451,#36447 and blocked in desktop with KI36368
#34303 failing with #36433 on desktop
#34963 blocked by #36479
#35287 blocked by #36433
#35841 failing with #36434 but closed as not reproduced, checking it off
#35853 blocked by #36433
#36204 blocked by #36433 in iOS (tester does not have an account with previous requests to validate the PR. Because PR steps does not require a new IOU)
#35645 - Looks internal testing, can I check it off?

Open Blockers:
#36433
#36346
#36438
#36454
#36457
#36479
#36481
#36483
#36490
#36510
#36517

We are validating the 2 cps now.

[rlinoz]

Checking off #36510 as this is already in prod.

[amyevans]

Checked off #36454 following CP/retest

[mountiny]

checking #36479 off, its backend blocker

[AndrewGable]

Checked off #36517, it was fixed on staging by this CP https://github.com/Expensify/App/actions/runs/7909722028

[thienlnam]

Only fresh crash is for
ImageMetaData.getColorSpace - which only happened for 1 user on 1.4.38-6 so it seems fine to ignore

[thienlnam]

Kicking off the deploy so we can get this fireroom fix to prod

[thienlnam]

[os-botify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[melvin-bot]

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[thienlnam]