Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-06-09] [Group 2][Accessible Pressable] Migrate CheckboxWithLabel #17018

Closed
roryabraham opened this issue Apr 6, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate CheckboxWithLabel to use PressableWithFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0100b9d4c98e40928e
  • Upwork Job ID: 1667276796449763328
  • Last Price Increase: 2023-06-09
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 2][Accessible Pressable] Migrate CheckboxWithLabel [Group 2][Accessible Pressable] Migrate CheckboxWithLabel May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 11, 2023
@robertKozik
Copy link
Contributor

Hi, could you assign me to this issue? Here is ready PR: #18792 (comment)

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables May 16, 2023
@marcaaron
Copy link
Contributor

I'm going to assign you to this one @roryabraham since you are managing the project and should also review (I think?)

@marcaaron
Copy link
Contributor

I got assigned to #18792 but I'm going OOO and I think you have more context than me on the changes.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jun 2, 2023
@melvin-bot melvin-bot bot changed the title [Group 2][Accessible Pressable] Migrate CheckboxWithLabel [HOLD for payment 2023-06-09] [Group 2][Accessible Pressable] Migrate CheckboxWithLabel Jun 2, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.22-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 8, 2023
@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Jun 9, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-09] [Group 2][Accessible Pressable] Migrate CheckboxWithLabel [$1000] [HOLD for payment 2023-06-09] [Group 2][Accessible Pressable] Migrate CheckboxWithLabel Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0100b9d4c98e40928e

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Current assignee @roryabraham is eligible for the External assigner, not assigning anyone new.

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

📣 @Santhosh-Sellavel You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@roryabraham
Copy link
Contributor Author

@kadiealexander the only payment due here is $1000 to @Santhosh-Sellavel for the C+ review. It's ready to pay out immediately, then we can close this.

@kadiealexander
Copy link
Contributor

kadiealexander commented Jun 12, 2023

@Santhosh-Sellavel I've sent you an Upwork offer :)

@kadiealexander
Copy link
Contributor

Payment issued!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants