only add taxCode in changes if availble in policy.

Signed-off-by: krishna2323 <[email protected]>
Expensify · Sep 16, 2024 · 9801ae8 · 9801ae8
1 parent 5fff73f
commit 9801ae8
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/libs/TransactionUtils/index.ts b/src/libs/TransactionUtils/index.ts
@@ -1024,12 +1024,10 @@ function compareDuplicateTransactionFields(transactionID: string, reportID: stri
                 const report = ReportConnection.getAllReports()?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`] ?? null;
                 const policy = PolicyUtils.getPolicy(report?.policyID);
                 const differentValues = getDifferentValues(transactions, keys);
-                const hasValidTaxes = differentValues?.filter((taxID) => PolicyUtils.getTaxByID(policy, (taxID as string) ?? '')?.name).length;
+                const validTaxes = differentValues?.filter((taxID) => PolicyUtils.getTaxByID(policy, (taxID as string) ?? '')?.name);
 
-                if (areAllFieldsEqual(transactions, (item) => keys.map((key) => item?.[key]).join('|')) || !hasValidTaxes) {
-                    keep[fieldName] = firstTransaction?.[keys[0]] ?? firstTransaction?.[keys[1]];
-                } else {
-                    processChanges(fieldName, transactions, keys);
+                if (!areAllFieldsEqual(transactions, (item) => keys.map((key) => item?.[key]).join('|')) && validTaxes.length > 1) {
+                    change[fieldName] = validTaxes;
                 }
             } else if (areAllFieldsEqual(transactions, (item) => keys.map((key) => item?.[key]).join('|'))) {
                 keep[fieldName] = firstTransaction?.[keys[0]] ?? firstTransaction?.[keys[1]];