Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert Apollo Runtime Dependency to Gradle "api" #33

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

Mohammad-Dwairi
Copy link
Contributor

@Mohammad-Dwairi Mohammad-Dwairi commented Sep 13, 2024

Summary

We encountered an issue with the SDK where users needed to manually add the Apollo Kotlin Runtime as a dependency in order to use the SDK. This issue has been resolved in this PR by marking the Apollo Runtime dependency as api() instead of implementation.

Dependencies marked as api will be available to the consumer’s classpath, which - in our case - makes Apollo Kotlin available automatically.

Note

Published new 0.0.3-SNAPSHOT artifacts with these changes.

@Mohammad-Dwairi Mohammad-Dwairi requested a review from a team as a code owner September 13, 2024 13:33
@Mohammad-Dwairi Mohammad-Dwairi merged commit 188f752 into main Sep 15, 2024
1 check passed
@Mohammad-Dwairi Mohammad-Dwairi deleted the mdwairi/fix-apollo-dependecy-issue branch September 15, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants