fix: use RequestExecutor the Bearer AuthenticationManager #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
The current
BearerAuthenticationManager
expects aTransport
in its constructor in order to use it for authentication requests. However, using a rawTransport
makes the authentication requests to be executed outside the interceptors defined by the SDK, as these interceptors take place in the higher-levelRequestExecutor
.By using the
RequestExecutor
instead ofTransport
in theBearerAuthenticationManager
, all authentication requests will go through the same interceptors pipeline defined in the passedRequestExecutor
.Task
Modify the
BearerAuthenticationManager
to accept aRequestExecutor
instead ofTransport
in its constructor, applying any needed changes along with this change.Action
RequestExecutor
to acceptRequestExecutor
instead ofTransport
.BearerAuthenticationManager
, Request/Response logging is now handled by theLoggingInterceptor
even on the authentication requests.LoggingInterceptor
instead of injecting it from outside.Testing
Results
Authentication requests made by the
BearerAuthenticationManager
are now going through the defined pipeline of interceptors defined by the SDK.