fix: default OkHttpClient enhancements and testing #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
With the introduction of the new SDK core, we need to raise the tests coverage before attempting to migrate the core module to the original repository. We will be testing the new core with this LC SDK during this temporary phase.
We pushed the new core initially as an PoC. However, we are revising each module to cleanup, improve, and test.
Task
OkHttpClient
in the new core with unit tests.Action
Code Enhancements
BaseOkHttpClient
that was used in the singleton pattern and relied on eager initialization of the default instance.OkHttpTransport
implementationCode Tests
com.expediagroup.sdk.core.okhttp
package with Kotlin tests and Java tests if needed.Testing
All tests are passing
Results