Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to ktor v3 #914

Merged
merged 48 commits into from
Feb 3, 2025
Merged

chore: upgrade to ktor v3 #914

merged 48 commits into from
Feb 3, 2025

Conversation

anssari1
Copy link
Contributor

@anssari1 anssari1 commented Dec 23, 2024

Situation

  • Request bodies are not logged. Ktor 2 logging plugin does not work with gzipped content, so we created custom logging plugins. Ktor 3 resolved this issue.
  • EJMask does not support masking nested fields

Action

  • Upgraded to Ktor 3
  • Removed custom logging plugins
  • Updated pagination handling to do away with content decoding
  • Removed EJMask

Testing

  • All unit tests fixed
  • Examples run
Screenshot 2025-01-26 at 5 29 35 PM

Results

Notes

@anssari1 anssari1 marked this pull request as ready for review January 15, 2025 10:08
@anssari1 anssari1 requested a review from a team as a code owner January 15, 2025 10:08
dtayeh
dtayeh previously approved these changes Jan 29, 2025
@dtayeh
Copy link
Contributor

dtayeh commented Jan 29, 2025

Logs from local test:
7:39:15.573 [DefaultDispatcher-worker-8] INFO com.expediagroup.sdk.core.client.Client - ExpediaSDK: REQUEST: https://test.ean.com/v3/itineraries?token=QldfCGlcUA4FV1FWBwIFVwxDRwdWXBBLDwheZkFdBwVSU15SVwtXABlWCABRSwcHX1wYXFMHVUwEXFRQBFQGUAIPBVIQXlVHVApVC0BrDlBnQ1BWWxYBD3w9YHNxcSceQBZfUFI-UAtZWgMEUAVUAFUVUENDVk0AbApXCwZRBVcLBwEKCRNADUNdORZNEVUOTRNYVQtMCFcPVA1tVhQMRUZQQEMJVgFBRQBfBU0OBhQMUUMJB0ILDVZrBABUCAMXAwNEWwVYXk0AU1wOUQgYbGoWEVpNQ1AGCUZRFFtQSEMXC1EBSAZYBABTRUNVEVQ8TE1IAQpgYCJ6InQ3IhEIXRE7RlUXV0ZeUQddFVEfAFQRWAUFVRFVUFJRDgoMCgpUAlAaUwYfAVoTEVlLQAtWQj5BQVgCDF9dOV8CBAcIVwwPVB5ZBw5SVRENA1lYElFDAUYUEwBdUUoFMWp8RA5FE1FCBgtbTAoJWWtQCVABD2QxIEAXVAQTDQEHAFtSXwRTXEtVQ1tURlhSEAgMU2lTDVkLWwdcBFIfBQ5cWl5bFkxbA1YBABRUURlVAEJWA1dpUAEIV1MDVFAXTRJdVlsDAg0GEUBeXEBFXgxTOkRVFV4FYmF0eiAkfnYrdRBXVAlbWztbVloDVhFnWwoNTWdWBFgKRlhXVlUWVkVSW1sTXRAEAh4LBBNBAVFdFBBdD1dsSg5MQwFdXEoARQhWGRYRW1ZQHwYOUAFfEwJEFUBcWVcTb0IHEUULDF9rCwEMDAoIUA4HB1cbCF0DBxQHAVVWFAECB1MVBQVXAwQJAgtRUABQREEBFhZZDg1nClUJV1JRW1cNUQ4eUFEGXxhRA1UDFV0GV1ZOAVMGUVcAUQYNAVFQFxFKCkdTSkNLOgoGCglVB1ICVAEGFgVQD11LVRFWVD5FWloBWAEIVANLCQAUVw1iVQwRUSIDCUYDJAkBTwBVWwJeUFQLCmkeF1hUBxdvBFZHCxBXVg4DWUAODlsQV109DggJSEQSEQQQB1toEhdAQFdDAAtgenh5KzYsa2JiJG4geT1gbDBpKTV8H1ZbFlYSQx9sVlYABgkxakJWA1dpXQBGBxZcExVYVgwJA0MEAmBBXl0TAQB3UgYRVwRVD1IdAwUEEVZVZk4MXhMHCCRNXg8TAQcjVgceVgEFa1tdD18PUhBDVk0MXA0OEwEkFlN7EwIBRExDARIKVEcHIBUBCzVOWAx6BFxEB1MXBiVGAAdGWx8DEFAGEFJwQwYBYEUIXhRQUBNQIBQGUBREVF1NWkMbElYEHAsgBRwEcEMHehwHIBAKA0caRFEVVgARVnJAUAAmEAtbIwZcRgMGQAMgHQYKF15JUUYGVBBWJxJUCjETXVpGAAdGBSUUVAZIEFQPRQhMHBIEChIBJFJHAHxBBSEREEFCQA5cBEpmXQEOAlUXcF8BBlhLE1tbCwkPUgQPXAEMVw== METHOD: HttpMethod(value=POST) COMMON HEADERS -> Accept: application/json -> Accept-Charset: UTF-8 -> Accept-Encoding: gzip -> Authorization: <-- omitted --> -> Customer-Ip: 127.0.0.1 -> User-Agent: expediagroup-sdk-java-rapid/5.3.2-SNAPSHOT (Java 22; Mac OS X 14.4.1) -> transaction-id: bc7f10a3-cfb6-415c-aea4-b68fc0cfb354 -> x-sdk-title: rapid-sdk CONTENT HEADERS -> Content-Type: application/json BODY Content-Type: application/json BODY START {"email":"[email protected]","phone":{"country_code":"1","number":"5550077","area_code":"487"},"rooms":[{"given_name":"John","family_name":"Smith","smoking":false,"special_request":"Please provide a room with a view of the ocean.","loyalty_id":null,"loyalty":null}],"affiliate_reference_id":"8f712a36-47f1-4176-b8f9-c0d9","hold":false,"payments":[{"type":"customer_card","billing_contact":{"given_name":"John","family_name":"Smith","address":{"country_code":"US","line_1":"555 1st St","line_2":"10th Floor","line_3":"Unit 12","city":"Seattle","state_province_code":"WA","postal_code":"98121"}},"number":"<-- omitted -->","security_code":"<-- omitted -->","expiration_month":"08","expiration_year":"2025","third_party_authentication":null,"enrollment_date":"2018-09-15"}],"affiliate_metadata":"data_point_1:123|data_point2:This is data.","tax_registration_number":"12345678910","traveler_handling_instructions":"Please use the card provided for payment. Avoid cancellation as this is for a corporate traveler. Contact traveler if any issues.","invoicing":null}

@anssari1 anssari1 merged commit bacec7e into main Feb 3, 2025
4 checks passed
@anssari1 anssari1 deleted the nanssari/ktor_3 branch February 3, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants