Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't consider existing ref an error #60

Merged

Conversation

sparten11740
Copy link
Collaborator

Sometimes when retrying tag creation there is an issue where the tag creation completes on GH side, but the call throws an error. The next call will then error with "Reference already exists". This PR makes sure we don't consider that an error because it's the desired target state.

Copy link

@andrejborstnik andrejborstnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sparten11740 sparten11740 merged commit 894ece0 into master Dec 20, 2024
2 checks passed
@sparten11740 sparten11740 deleted the sparten11740/fix/dont-retry-when-reference-already-exists branch December 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants